[Security Solution] Security Assistant: adds the assistantEnabled fea…

…ture flag (elastic#17) ## Summary - adds the `assistantEnabled` feature flag (default: `false`) in `x-pack/plugins/security_solution/common/experimental_features.ts`
andrew-goldstein · Jun 2, 2023 · 4385ffd · 4385ffd
1 parent 705f9ee
commit 4385ffd
Show file tree

Hide file tree

Showing 28 changed files with 131 additions and 41 deletions.
diff --git a/x-pack/packages/kbn-elastic-assistant/impl/assistant/context_pills/index.tsx b/x-pack/packages/kbn-elastic-assistant/impl/assistant/context_pills/index.tsx
@@ -6,11 +6,10 @@
  */
 
 import { EuiButton, EuiFlexGroup, EuiFlexItem, EuiToolTip } from '@elastic/eui';
-// eslint-disable-next-line @kbn/eslint/module_migration
-import styled from 'styled-components';
-
 import { sortBy } from 'lodash/fp';
 import React, { useCallback, useMemo } from 'react';
+// eslint-disable-next-line @kbn/eslint/module_migration
+import styled from 'styled-components';
 
 import type { PromptContext } from '../prompt_context/types';
 

diff --git a/...ges/kbn-elastic-assistant/impl/assistant/prompt_editor/selected_prompt_contexts/index.tsx b/...ges/kbn-elastic-assistant/impl/assistant/prompt_editor/selected_prompt_contexts/index.tsx
@@ -56,17 +56,25 @@ const SelectedPromptContextsComponent: React.FC<Props> = ({
   );
 
   useEffect(() => {
+    const abortController = new AbortController();
+
     const fetchAccordionContent = async () => {
       const newAccordionContent = await Promise.all(
         selectedPromptContexts.map(async ({ getPromptContext, id }) => ({
           [id]: await getPromptContext(),
         }))
       );
 
-      setAccordionContent(newAccordionContent.reduce((acc, curr) => ({ ...acc, ...curr }), {}));
+      if (!abortController.signal.aborted) {
+        setAccordionContent(newAccordionContent.reduce((acc, curr) => ({ ...acc, ...curr }), {}));
+      }
     };
 
     fetchAccordionContent();
+
+    return () => {
+      abortController.abort();
+    };
   }, [selectedPromptContexts]);
 
   if (isEmpty(promptContexts)) {

diff --git a/...y_dashboard/impl/data_quality/data_quality_panel/body/data_quality_details/index.test.tsx b/...y_dashboard/impl/data_quality/data_quality_panel/body/data_quality_details/index.test.tsx
@@ -55,6 +55,7 @@ const defaultProps: Props = {
   formatNumber,
   getGroupByFieldsOnClick: jest.fn(),
   ilmPhases,
+  isAssistantEnabled: true,
   openCreateCaseFlyout: jest.fn(),
   patternIndexNames,
   patternRollups,

diff --git a/...uality_dashboard/impl/data_quality/data_quality_panel/body/data_quality_details/index.tsx b/...uality_dashboard/impl/data_quality/data_quality_panel/body/data_quality_details/index.tsx
@@ -41,6 +41,7 @@ export interface Props {
     groupByField1: string;
   };
   ilmPhases: string[];
+  isAssistantEnabled: boolean;
   openCreateCaseFlyout: ({
     comments,
     headerContent,
@@ -69,6 +70,7 @@ const DataQualityDetailsComponent: React.FC<Props> = ({
   formatNumber,
   getGroupByFieldsOnClick,
   ilmPhases,
+  isAssistantEnabled,
   openCreateCaseFlyout,
   patternIndexNames,
   patternRollups,
@@ -105,6 +107,7 @@ const DataQualityDetailsComponent: React.FC<Props> = ({
         formatNumber={formatNumber}
         getGroupByFieldsOnClick={getGroupByFieldsOnClick}
         ilmPhases={ilmPhases}
+        isAssistantEnabled={isAssistantEnabled}
         openCreateCaseFlyout={openCreateCaseFlyout}
         patterns={patterns}
         theme={theme}

diff --git a/.../data_quality/data_quality_panel/body/data_quality_details/indices_details/index.test.tsx b/.../data_quality/data_quality_panel/body/data_quality_details/indices_details/index.test.tsx
@@ -55,6 +55,7 @@ const defaultProps: Props = {
   formatNumber,
   getGroupByFieldsOnClick: jest.fn(),
   ilmPhases,
+  isAssistantEnabled: true,
   openCreateCaseFlyout: jest.fn(),
   patternIndexNames,
   patternRollups,

diff --git a/.../impl/data_quality/data_quality_panel/body/data_quality_details/indices_details/index.tsx b/.../impl/data_quality/data_quality_panel/body/data_quality_details/indices_details/index.tsx
@@ -39,6 +39,7 @@ export interface Props {
     groupByField1: string;
   };
   ilmPhases: string[];
+  isAssistantEnabled: boolean;
   openCreateCaseFlyout: ({
     comments,
     headerContent,
@@ -69,6 +70,7 @@ const IndicesDetailsComponent: React.FC<Props> = ({
   formatNumber,
   getGroupByFieldsOnClick,
   ilmPhases,
+  isAssistantEnabled,
   openCreateCaseFlyout,
   patternIndexNames,
   patternRollups,
@@ -90,6 +92,7 @@ const IndicesDetailsComponent: React.FC<Props> = ({
           getGroupByFieldsOnClick={getGroupByFieldsOnClick}
           ilmPhases={ilmPhases}
           indexNames={patternIndexNames[pattern]}
+          isAssistantEnabled={isAssistantEnabled}
           openCreateCaseFlyout={openCreateCaseFlyout}
           pattern={pattern}
           patternRollup={patternRollups[pattern]}

diff --git a/...ution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/body/index.test.tsx b/...ution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/body/index.test.tsx
@@ -35,6 +35,7 @@ describe('IndexInvalidValues', () => {
           formatNumber={formatNumber}
           getGroupByFieldsOnClick={jest.fn()}
           ilmPhases={[]}
+          isAssistantEnabled={true}
           lastChecked={''}
           openCreateCaseFlyout={jest.fn()}
           patterns={[]}
@@ -63,6 +64,7 @@ describe('IndexInvalidValues', () => {
               formatNumber={formatNumber}
               getGroupByFieldsOnClick={jest.fn()}
               ilmPhases={ilmPhases}
+              isAssistantEnabled={true}
               lastChecked={''}
               openCreateCaseFlyout={jest.fn()}
               patterns={patterns}
@@ -88,6 +90,7 @@ describe('IndexInvalidValues', () => {
             formatNumber={formatNumber}
             getGroupByFieldsOnClick={jest.fn()}
             ilmPhases={ilmPhases}
+            isAssistantEnabled={true}
             lastChecked={''}
             openCreateCaseFlyout={jest.fn()}
             patterns={patterns}

diff --git a/...y-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/body/index.tsx b/...y-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/body/index.tsx
@@ -40,6 +40,7 @@ interface Props {
     groupByField1: string;
   };
   ilmPhases: string[];
+  isAssistantEnabled: boolean;
   lastChecked: string;
   openCreateCaseFlyout: ({
     comments,
@@ -60,6 +61,7 @@ const BodyComponent: React.FC<Props> = ({
   formatNumber,
   getGroupByFieldsOnClick,
   ilmPhases,
+  isAssistantEnabled,
   lastChecked,
   openCreateCaseFlyout,
   patterns,
@@ -112,6 +114,7 @@ const BodyComponent: React.FC<Props> = ({
           formatNumber={formatNumber}
           getGroupByFieldsOnClick={getGroupByFieldsOnClick}
           ilmPhases={ilmPhases}
+          isAssistantEnabled={isAssistantEnabled}
           openCreateCaseFlyout={openCreateCaseFlyout}
           patterns={patterns}
           patternIndexNames={patternIndexNames}

diff --git a/...ta_quality_dashboard/impl/data_quality/data_quality_panel/index_properties/index.test.tsx b/...ta_quality_dashboard/impl/data_quality/data_quality_panel/index_properties/index.test.tsx
@@ -111,6 +111,7 @@ const defaultProps: Props = {
   getGroupByFieldsOnClick: jest.fn(),
   ilmPhase: 'hot',
   indexName: 'auditbeat-custom-index-1',
+  isAssistantEnabled: true,
   openCreateCaseFlyout: jest.fn(),
   pattern,
   patternRollup,

diff --git a/...cs_data_quality_dashboard/impl/data_quality/data_quality_panel/index_properties/index.tsx b/...cs_data_quality_dashboard/impl/data_quality/data_quality_panel/index_properties/index.tsx
@@ -60,6 +60,7 @@ export interface Props {
   };
   ilmPhase: IlmPhase | undefined;
   indexName: string;
+  isAssistantEnabled: boolean;
   openCreateCaseFlyout: ({
     comments,
     headerContent,
@@ -82,6 +83,7 @@ const IndexPropertiesComponent: React.FC<Props> = ({
   getGroupByFieldsOnClick,
   ilmPhase,
   indexName,
+  isAssistantEnabled,
   openCreateCaseFlyout,
   pattern,
   patternRollup,
@@ -143,6 +145,7 @@ const IndexPropertiesComponent: React.FC<Props> = ({
         docsCount,
         getGroupByFieldsOnClick,
         ilmPhase,
+        isAssistantEnabled,
         indexName,
         onAddToNewCase,
         partitionedFieldMetadata: partitionedFieldMetadata ?? EMPTY_METADATA,
@@ -161,6 +164,7 @@ const IndexPropertiesComponent: React.FC<Props> = ({
       getGroupByFieldsOnClick,
       ilmPhase,
       indexName,
+      isAssistantEnabled,
       onAddToNewCase,
       partitionedFieldMetadata,
       pattern,

diff --git a/...on/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/pattern/index.test.tsx b/...on/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/pattern/index.test.tsx
@@ -46,6 +46,7 @@ const defaultProps = {
   getGroupByFieldsOnClick: jest.fn(),
   ilmPhases: ['hot', 'warm', 'unmanaged'],
   indexNames: undefined,
+  isAssistantEnabled: true,
   openCreateCaseFlyout: jest.fn(),
   patternRollup: undefined,
   selectedIndex: null,

diff --git a/...olution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/pattern/index.tsx b/...olution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/pattern/index.tsx
@@ -76,6 +76,7 @@ interface Props {
   };
   ilmPhases: string[];
   indexNames: string[] | undefined;
+  isAssistantEnabled: boolean;
   openCreateCaseFlyout: ({
     comments,
     headerContent,
@@ -106,6 +107,7 @@ const PatternComponent: React.FC<Props> = ({
   getGroupByFieldsOnClick,
   indexNames,
   ilmPhases,
+  isAssistantEnabled,
   openCreateCaseFlyout,
   pattern,
   patternRollup,
@@ -150,6 +152,7 @@ const PatternComponent: React.FC<Props> = ({
                 getGroupByFieldsOnClick={getGroupByFieldsOnClick}
                 ilmPhase={ilmExplain != null ? getIlmPhase(ilmExplain[indexName]) : undefined}
                 indexName={indexName}
+                isAssistantEnabled={isAssistantEnabled}
                 openCreateCaseFlyout={openCreateCaseFlyout}
                 pattern={pattern}
                 patternRollup={patternRollup}
@@ -168,6 +171,7 @@ const PatternComponent: React.FC<Props> = ({
       formatNumber,
       getGroupByFieldsOnClick,
       ilmExplain,
+      isAssistantEnabled,
       itemIdToExpandedRowMap,
       openCreateCaseFlyout,
       pattern,

diff --git a/...ion/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/tabs/helpers.test.tsx b/...ion/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/tabs/helpers.test.tsx
@@ -77,6 +77,7 @@ describe('helpers', () => {
           getGroupByFieldsOnClick: jest.fn(),
           ilmPhase: 'unmanaged',
           indexName: 'auditbeat-custom-index-1',
+          isAssistantEnabled: true,
           onAddToNewCase: jest.fn(),
           partitionedFieldMetadata: mockPartitionedFieldMetadata,
           pattern: 'auditbeat-*',

diff --git a/...solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/tabs/helpers.tsx b/...solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/tabs/helpers.tsx
@@ -66,6 +66,7 @@ export const getTabs = ({
   getGroupByFieldsOnClick,
   ilmPhase,
   indexName,
+  isAssistantEnabled,
   onAddToNewCase,
   partitionedFieldMetadata,
   pattern,
@@ -94,6 +95,7 @@ export const getTabs = ({
   };
   ilmPhase: IlmPhase | undefined;
   indexName: string;
+  isAssistantEnabled: boolean;
   onAddToNewCase: (markdownComments: string[]) => void;
   partitionedFieldMetadata: PartitionedFieldMetadata;
   pattern: string;
@@ -113,6 +115,7 @@ export const getTabs = ({
         getGroupByFieldsOnClick={getGroupByFieldsOnClick}
         ilmPhase={ilmPhase}
         indexName={indexName}
+        isAssistantEnabled={isAssistantEnabled}
         onAddToNewCase={onAddToNewCase}
         partitionedFieldMetadata={partitionedFieldMetadata}
         pattern={pattern}
@@ -140,6 +143,7 @@ export const getTabs = ({
         formatNumber={formatNumber}
         ilmPhase={ilmPhase}
         indexName={indexName}
+        isAssistantEnabled={isAssistantEnabled}
         onAddToNewCase={onAddToNewCase}
         partitionedFieldMetadata={partitionedFieldMetadata}
         patternDocsCount={patternDocsCount}

diff --git a/...ta_quality_dashboard/impl/data_quality/data_quality_panel/tabs/incompatible_tab/index.tsx b/...ta_quality_dashboard/impl/data_quality/data_quality_panel/tabs/incompatible_tab/index.tsx
@@ -51,6 +51,7 @@ interface Props {
   formatNumber: (value: number | undefined) => string;
   ilmPhase: IlmPhase | undefined;
   indexName: string;
+  isAssistantEnabled: boolean;
   onAddToNewCase: (markdownComments: string[]) => void;
   partitionedFieldMetadata: PartitionedFieldMetadata;
   patternDocsCount: number;
@@ -65,6 +66,7 @@ const IncompatibleTabComponent: React.FC<Props> = ({
   formatNumber,
   ilmPhase,
   indexName,
+  isAssistantEnabled,
   onAddToNewCase,
   partitionedFieldMetadata,
   patternDocsCount,
@@ -139,16 +141,18 @@ const IncompatibleTabComponent: React.FC<Props> = ({
                 </CopyToClipboardButton>
               </EuiFlexItem>
 
-              <EuiFlexItem grow={false}>
-                <NewChat
-                  category="data-quality-dashboard"
-                  conversationId={DATA_QUALITY_DASHBOARD_CONVERSATION_ID}
-                  description={DATA_QUALITY_PROMPT_CONTEXT_PILL(indexName)}
-                  getPromptContext={getPromptContext}
-                  suggestedUserPrompt={DATA_QUALITY_SUGGESTED_USER_PROMPT}
-                  tooltip={DATA_QUALITY_PROMPT_CONTEXT_PILL_TOOLTIP}
-                />
-              </EuiFlexItem>
+              {isAssistantEnabled && (
+                <EuiFlexItem grow={false}>
+                  <NewChat
+                    category="data-quality-dashboard"
+                    conversationId={DATA_QUALITY_DASHBOARD_CONVERSATION_ID}
+                    description={DATA_QUALITY_PROMPT_CONTEXT_PILL(indexName)}
+                    getPromptContext={getPromptContext}
+                    suggestedUserPrompt={DATA_QUALITY_SUGGESTED_USER_PROMPT}
+                    tooltip={DATA_QUALITY_PROMPT_CONTEXT_PILL_TOOLTIP}
+                  />
+                </EuiFlexItem>
+              )}
             </EuiFlexGroup>
           </IncompatibleCallout>
 

diff --git a/...dashboard/impl/data_quality/data_quality_panel/tabs/summary_tab/callout_summary/index.tsx b/...dashboard/impl/data_quality/data_quality_panel/tabs/summary_tab/callout_summary/index.tsx
@@ -33,6 +33,7 @@ interface Props {
   formatNumber: (value: number | undefined) => string;
   ilmPhase: IlmPhase | undefined;
   indexName: string;
+  isAssistantEnabled: boolean;
   onAddToNewCase: (markdownComment: string[]) => void;
   partitionedFieldMetadata: PartitionedFieldMetadata;
   pattern: string;
@@ -48,6 +49,7 @@ const CalloutSummaryComponent: React.FC<Props> = ({
   formatNumber,
   ilmPhase,
   indexName,
+  isAssistantEnabled,
   onAddToNewCase,
   partitionedFieldMetadata,
   pattern,
@@ -132,16 +134,18 @@ const CalloutSummaryComponent: React.FC<Props> = ({
               </CopyToClipboardButton>
             </EuiFlexItem>
 
-            <EuiFlexItem grow={false}>
-              <NewChat
-                conversationId={DATA_QUALITY_DASHBOARD_CONVERSATION_ID}
-                category="data-quality-dashboard"
-                description={DATA_QUALITY_PROMPT_CONTEXT_PILL(indexName)}
-                getPromptContext={getPromptContext}
-                suggestedUserPrompt={DATA_QUALITY_SUGGESTED_USER_PROMPT}
-                tooltip={DATA_QUALITY_PROMPT_CONTEXT_PILL_TOOLTIP}
-              />
-            </EuiFlexItem>
+            {isAssistantEnabled && (
+              <EuiFlexItem grow={false}>
+                <NewChat
+                  conversationId={DATA_QUALITY_DASHBOARD_CONVERSATION_ID}
+                  category="data-quality-dashboard"
+                  description={DATA_QUALITY_PROMPT_CONTEXT_PILL(indexName)}
+                  getPromptContext={getPromptContext}
+                  suggestedUserPrompt={DATA_QUALITY_SUGGESTED_USER_PROMPT}
+                  tooltip={DATA_QUALITY_PROMPT_CONTEXT_PILL_TOOLTIP}
+                />
+              </EuiFlexItem>
+            )}
           </EuiFlexGroup>
 
           <EuiSpacer size="s" />

diff --git a/...cs_data_quality_dashboard/impl/data_quality/data_quality_panel/tabs/summary_tab/index.tsx b/...cs_data_quality_dashboard/impl/data_quality/data_quality_panel/tabs/summary_tab/index.tsx
@@ -42,6 +42,7 @@ interface Props {
   };
   ilmPhase: IlmPhase | undefined;
   indexName: string;
+  isAssistantEnabled: boolean;
   onAddToNewCase: (markdownComments: string[]) => void;
   partitionedFieldMetadata: PartitionedFieldMetadata;
   pattern: string;
@@ -60,6 +61,7 @@ const SummaryTabComponent: React.FC<Props> = ({
   getGroupByFieldsOnClick,
   ilmPhase,
   indexName,
+  isAssistantEnabled,
   onAddToNewCase,
   partitionedFieldMetadata,
   pattern,
@@ -77,6 +79,7 @@ const SummaryTabComponent: React.FC<Props> = ({
       docsCount={docsCount}
       ilmPhase={ilmPhase}
       indexName={indexName}
+      isAssistantEnabled={isAssistantEnabled}
       onAddToNewCase={onAddToNewCase}
       partitionedFieldMetadata={partitionedFieldMetadata}
       pattern={pattern}