Adds a gc for size and expiry #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a _lot_ more I could do with this, need to avoid wanting it to be perfect before merging. Needs more high-level tests, though. Signed-off-by: Andrew Aylett <andrew@aylett.co.uk>
This makes it easier to test validity, I'm really enjoying being able to have nicely typed custom matchers. Signed-off-by: Andrew Aylett <andrew@aylett.co.uk>
Also factors in a supplier for the current instant, so I can override it in tests, and factors out expect extensions into a separate package for the mechanics and separate files for the extensions in use in this project. Signed-off-by: Andrew Aylett <andrew@aylett.co.uk>
We don't want Jest to run built tests, nor to include them in the package. But we do want our tooling to type check the source. Signed-off-by: Andrew Aylett <andrew@aylett.co.uk>
Signed-off-by: Andrew Aylett <andrew@aylett.co.uk>
JS and TS are formatted with Prettier, which works off editorconfig configuration, but doesn't _always_ indent by a multiple of the configured value for ternaries or block comments. Prettier is doing the right thing, so leave it to it. Signed-off-by: Andrew Aylett <andrew@aylett.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses cache-control
max-ageand theageheader to work out when to expire entriesSigned-off-by: Andrew Aylett andrew@aylett.co.uk