Fix hanging test

andrewbaldwin44 · Jan 19, 2024 · a382084 · a382084
1 parent f5e235d
commit a382084
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -19,7 +19,12 @@ jobs:
           - { name: "ruff", python: "3.11", os: ubuntu-latest, tox: "ruff" }
           - { name: "mypy", python: "3.10", os: ubuntu-latest, tox: "mypy" }
           # run some integration tests and abort immediately if they fail, for faster feedback
-          - { name: "fail_fast_test_main", python: "3.12", os: ubuntu-latest, tox: fail_fast_test_main }
+          - {
+              name: "fail_fast_test_main",
+              python: "3.12",
+              os: ubuntu-latest,
+              tox: fail_fast_test_main,
+            }
           - { name: "3.12", python: "3.12", os: ubuntu-latest, tox: py312 }
           - { name: "3.11", python: "3.11", os: ubuntu-latest, tox: py311 }
           - { name: "3.10", python: "3.10", os: ubuntu-latest, tox: py310 }
@@ -47,7 +52,7 @@ jobs:
       - run: python -m pip install tox
       - run: python -m tox -e ${{ matrix.tox }}
 
-  lint_typecheck_webui:
+  lint_typecheck_test_webui:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

diff --git a/locust/webui/src/components/SwarmForm/tests/SwarmUserClassPicker.test.tsx b/locust/webui/src/components/SwarmForm/tests/SwarmUserClassPicker.test.tsx
@@ -104,7 +104,7 @@ describe('SwarmForm', () => {
       fireEvent.click(getByRole('button', { name: 'Save' }));
     });
 
-    await waitFor(async () => {
+    waitFor(() => {
       const submittedData = updateUserSettings.mock.calls[0][0];
       if (submittedData) {
         expect(submittedData).toEqual({ ...mockUsers.Example, userClassName: 'Example' });
@@ -152,7 +152,7 @@ describe('SwarmForm', () => {
       fireEvent.click(getByRole('button', { name: 'Save' }));
     });
 
-    await waitFor(async () => {
+    waitFor(() => {
       const submittedData = updateUserSettings.mock.calls[0][0];
       if (submittedData) {
         expect(submittedData).toEqual({ ...updatedUser, userClassName: 'Example' });