Avoid conflicts with underscore #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh. Good addition. Merging. I'll also be taking a look at your other PRs, and the issues against Winterfell this weekend. Thanks! |
andrewhathaway
added a commit
that referenced
this pull request
Oct 7, 2015
Avoid conflicts with underscore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our environment we are using underscore. We found that the Winterfell version of lodash was overriding the global _ variable causing all kind of (not so) fun bugs.
To avoid that I added the .noConflict() method call to all places where lodash is included.
We tried using modular lodash, which we failed because Winterfell uses chaining. We also tried including it as an external dependency making it agnostic of both _ libraries which also failed because Winterfell uses methods that are not compatible with underscore.