Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing functions #25

Merged

Conversation

Emerentius
Copy link
Contributor

@Emerentius Emerentius commented Sep 18, 2020

Adds the following functions

  • canonicalize
  • hard link
  • read_link
  • rename
  • symlink_metadata
  • soft_link

which should be all missing ones except for set_permissions. I'm unsure how to handle the error for that one. Ideally, the error message would also contain what permissions were attempted to be set, but Permissions does not implement Display.
We could just leave it at the path. That's already more useful than std.

Fixes #24

* canonicalize
* hard link
* read_link
* rename
*symlink_metadata
* soft_link
@andrewhickman andrewhickman merged commit 99a2122 into andrewhickman:master Sep 18, 2020
@andrewhickman
Copy link
Owner

Thanks!

@Emerentius Emerentius mentioned this pull request Sep 19, 2020
@Emerentius Emerentius deleted the add_missing_functions branch September 19, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing functions
2 participants