Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't contain os-specific extensions, yet.
This also deprecates
File::from_options
as that seems to have only been defined to avoid wrappingOpenOptions
.That function could also be kept, but then it should work with both
fs_err::OpenOptions
andstd::fs::OpenOptions
. You'd have to introduce a new type parameter (breaking change) and some way to convertfs_err::OpenOptions
tostd::fs::OpenOptions
(can't beAsRef
btw, butBorrow
would work).I don't think it's worth it. It only exists in
fs_err
so the only people affected by deprecation are old users offs_err
. People migrating to the crate after this PR would never need the function.