Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed months for Polish locale #604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-sawicki
Copy link

For some reason after upgrading sugar to 2.0 Polish locale for months got mixed up - first and alternative forms switched places. I fixed that plus added proper endings for May (it was broken, so I couldn't use {Month3} for all months).
BTW. The documentation on using alternative/plural forms is really hard to find - I had to look up previous versions of this locale.

For some reason after upgrading sugar to 2.0 Polish locale for months got mixed up - first and alternative forms switched places. I fixed that plus added proper endings for May (it was broken, so I couldn't use {Month3} for all months).
BTW. The documentation on using alternative/plural forms is really hard to find - I had to look up previous versions of this locale.
@andrewplummer
Copy link
Owner

Hi... give me a bit and I will look into this. Thanks for helping out here.

@pepkin88
Copy link
Contributor

pepkin88 commented Feb 17, 2021

I think it should stay as it is now. The default should be the genitive case, as it is in v2. In my opinion, people expect date.format('{d} {month} {yyyy}', 'pl') to get properly formatted date, that is '17 lutego 2021', not the improper '17 luty 2021'.
The version 2 is backwards incompatible with 1 anyway, by the semver convention.

As for the missing | for May, yeah, it could be added there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants