Use recommended Redis separator (colon ":")

[aabrodskiy]

Thank you for maintaining this product!
It would be very convenient to use recommended and generally adopted Redis separator (colon) instead of the current "%&" separator.
This would make most Redis visualization tools automatically group items in the table and thus it would make debugging whole lot easier on large data sets.

This would be a small change in the return parameter of the below function:

def __get_primary_key(cls, primary_key_value: Any):
    """
    Returns the primary key value concatenated to the table name for uniqueness
    """
    table_name = (
        cls.__name__.lower() if cls._table_name is None else cls._table_name
    )
    return f"{table_name}_%&_{primary_key_value}"

return f"{table_name}:{primary_key_value}"

"

[andrewthetechie]

Thanks for the feedback! This sounds like a valuable change.

I'd happily accept a PR making this change. I'll see if I get some free time to do it myself in the future

[aabrodskiy]

Sorry Andrew, I'd be happy to contribute but not an expert on how to do so on github unfortunately :(

[andrewthetechie]

No problem.

If want to give it a try, check out https://docs.github.com/en/get-started/quickstart/contributing-to-projects as a guide to get started on forking and PRing on Github. Here is pydantic-aioredis's contributing guide https://github.com/andrewthetechie/pydantic-aioredis/blob/main/CONTRIBUTING.rst which has some documentation that might be helpful too

The tl;dr on the process would be:

• fork this repo
• Make the changes to your fork and commit them. pydantic-aioredis uses Conventional Commits for commit message https://www.conventionalcommits.org/en/v1.0.0/
• Update tests and any documentation
• Make a PR back to this repo

[andrewthetechie]

#269

This feature will be included in the 1.0.0 release once that PR is merged. I'm shooting to have it merged in the next 7 days.

[andrewthetechie]

This feature is included in https://github.com/andrewthetechie/pydantic-aioredis/releases/tag/v1.0.0 which is available in pypi now