Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README example has typo #545

Closed
kraczak opened this issue Mar 31, 2023 · 3 comments
Closed

README example has typo #545

kraczak opened this issue Mar 31, 2023 · 3 comments
Assignees
@andrewthetechie
Labels
documentation Improvements or additions to documentation

Comments

@kraczak
Copy link

kraczak commented Mar 31, 2023

If I understand it correctly,

assert this_book_from_redis[0].author == date(year=1851, month=10, day=18)

should be changed to

assert this_book_from_redis[0].published_on == date(year=1851, month=10, day=18)
@andrewthetechie andrewthetechie added the documentation Improvements or additions to documentation label Mar 31, 2023
andrewthetechie added a commit that referenced this issue Mar 31, 2023
@andrewthetechie
docs: update readme example
992c4a1 
#545
@andrewthetechie
Copy link
Owner

andrewthetechie commented Mar 31, 2023 •
edited
Loading

Good catch, fixed in 992c4a1.

Thanks!

@andrewthetechie
Copy link
Owner

@all-contributors please add @kraczak for doc.

@allcontributors allcontributors bot mentioned this issue Mar 31, 2023
Merged
@allcontributors
Copy link

@andrewthetechie

I've put up a pull request to add @kraczak! 🎉

@andrewthetechie andrewthetechie self-assigned this Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewthetechie andrewthetechie

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewthetechie @kraczak