Improve red boundaries

andrey-tech · Nov 25, 2023 · 6d8b3b0 · 6d8b3b0
1 parent f209d16
commit 6d8b3b0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/README.md b/README.md
@@ -129,15 +129,15 @@ based on [PHP Mess Detector](https://phpmd.org/) (PHPMD) tool.
 | cis    | [Class Interface Size](https://phpmd.org/rules/codesize.html#excessivepubliccount)                                                                                                                                               |         | 45    | 45    |        |
 | crap0  | [Change Risk Analysis and Predictions Index](https://www.artima.com/weblogs/viewpost.jsp?thread=210575) for 0% coverage                                                                                                          |         |       |       | 29     |
 | dit    | [Depth of Inheritance Tree](https://phpmd.org/rules/design.html#depthofinheritance)                                                                                                                                              |         | 6     |       |        |
-| hb     | [Halstead Bugs](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                                      |         |       |       | 0.19   |
-| hd     | [Halstead Difficulty](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                                |         |       |       | 20     |
-| he     | [Halstead Effort](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                                    |         |       |       | 8000   |
+| hb     | [Halstead Bugs](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                                      |         |       |       | ✓      |
+| hd     | [Halstead Difficulty](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                                |         |       |       | ✓      |
+| he     | [Halstead Effort](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                                    |         |       |       | ✓      |
 | hi     | [Halstead Intelligence Content](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                      |         |       |       | ✓      |
 | hl     | [Halstead Level](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                                     |         |       |       | ✓      |
 | hnd    | [Halstead Vocabulary](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                                |         |       |       | ✓      |
 | hnt    | [Halstead Length](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                                    |         |       |       | ✓      |
 | ht     | [Halstead Programming Time](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                          |         |       |       | ✓      |
-| hv     | [Halstead Volume](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                                    |         |       |       | 700    |
+| hv     | [Halstead Volume](https://en.wikipedia.org/wiki/Halstead_complexity_measures)                                                                                                                                                    |         |       |       | ✓      |
 | lloc   | Logical Lines Of Code                                                                                                                                                                                                            | ✓       |       |       |        |
 | loc    | [Lines Of Code](https://phpmd.org/rules/codesize.html#excessivemethodlength)                                                                                                                                                     |         | 1000  |       | 100    |
 | max mi | Maximum of [Maintainability Index](https://learn.microsoft.com/en-us/visualstudio/code-quality/code-metrics-maintainability-index-range-and-meaning?view=vs-2022)                                                                | 50      |       |       |        |
@@ -156,7 +156,7 @@ based on [PHP Mess Detector](https://phpmd.org/) (PHPMD) tool.
 | vars   | [Number of Properties](https://phpmd.org/rules/codesize.html#toomanyfields)                                                                                                                                                      |         | 15    | 15    |        |
 | wmc    | [Weighted Method Count](https://phpmd.org/rules/codesize.html#excessiveclasscomplexity)                                                                                                                                          |         | 50    | 50    |        |
 
-Note: ✓ - means there are no defined color boundaries for this metric.
+Note: ✓ - means there are no defined "red" color boundaries for this metric.
 
 <a id="configuration-yaml-file"></a>
 ## Configuration YAML file

diff --git a/config/pdepend-summary-formatter.yml.dist b/config/pdepend-summary-formatter.yml.dist
@@ -95,27 +95,23 @@ colorizer:
       # https://en.wikipedia.org/wiki/Halstead_complexity_measures
       hb:
         green: [ 0, 0.09 ]
-        yellow+bold: [ 0.10, 0.19 ]
-        red+bold: [ 0.20, null ]
+        yellow+bold: [ 0.10, null ]
 
       # https://en.wikipedia.org/wiki/Halstead_complexity_measures
       # https://github.com/escomplex/complexity-report/blob/master/.complexrc.example
       hd:
         green: [ 0, 15 ]
-        yellow+bold: [ 15, 20 ]
-        red+bold: [ 20, null ]
+        yellow+bold: [ 15, null ]
 
       # https://en.wikipedia.org/wiki/Halstead_complexity_measures
       hv:
         green: [ 0, 400 ]
-        yellow+bold: [ 400, 700 ]
-        red+bold: [ 700, null ]
+        yellow+bold: [ 400, null ]
 
       # https://en.wikipedia.org/wiki/Halstead_complexity_measures
       he:
-        green: [ 0, 4000 ]
-        yellow+bold: [ 4000, 8000 ]
-        red+bold: [ 8000, null ]
+        green: [ 0, 5000 ]
+        yellow+bold: [ 5000, null ]
 
       # https://www.artima.com/weblogs/viewpost.jsp?thread=210575
       # https://stackoverflow.com/questions/4731774/how-to-read-improve-c-r-a-p-index-calculated-by-php