-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #1
Conversation
It has been deprecated in favour of `nyc`, which is already installed
As reported by npm audit
For completeness: I discovered that the reason for why Forcing the repository to use node 10, makes coverage work just fine. |
... or not. However, removing |
I turned off cache in the nyc config and now it works without removing the |
This is quite embarrassing! I have been locked away most of the time in GHE at my job and never realised there was a PR here until you closed it 🤦 Kudos @mroderick and @artfulhacker for the feedback! I am quite glad someone found this boilerplate useful. I never had anyone star or fork any project ever so this is all quite surprising for me! I actually only used the boilerplate a couple of times. I mostly do these boilerplates once every couple of years and purely for research purposes, to establish the state of the art. I will probably do one in 2021 and will take inspiration from this! |
@mroderick I also noticed I may have caused some frustration to people trying to make nyc work here https://github.com/andrezero/boilerplate-esm-nyc-mocha/issues Do you believe this boilerplate is still relevant in 2021? If so, do you mind reopening a PR with all the tweaks you have done on your side? If not I will probably add a big warning to the README! |
I think this boilerplate is still very relevant, as it shows people that it's still possible to get work done with minimal use of packages. |
very ❤️ warming @mroderick and uplifting thank you so much for not giving up on me |
This PR upgrades the participating dependencies to latest
Background
I was trying to figure out why
nyc
failed to report coverage properly in my repository, when I came across this repository.Thinking that it might recent changes that caused
nyc
to miscalculate for my repository, I tried upgrading dependencies in this repository. It still works just fineSolution
Upgrade dependencies, so others might not spend as long on it as I have
How to verify
npm ci
npm test
nyc
still calculates coverage correctly for all files