Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #1

Merged
merged 5 commits into from
Jan 27, 2021
Merged

Conversation

mroderick
Copy link
Contributor

This PR upgrades the participating dependencies to latest

Background

I was trying to figure out why nyc failed to report coverage properly in my repository, when I came across this repository.

Thinking that it might recent changes that caused nyc to miscalculate for my repository, I tried upgrading dependencies in this repository. It still works just fine

Solution

Upgrade dependencies, so others might not spend as long on it as I have

How to verify

  1. Check out this branch
  2. npm ci
  3. npm test
  4. Observe that nyc still calculates coverage correctly for all files

@mroderick
Copy link
Contributor Author

For completeness: I discovered that the reason for why nyc was not working in my repository, was that I was using node 12, which has some open issue: istanbuljs/nyc#1104.

Forcing the repository to use node 10, makes coverage work just fine.

@mroderick
Copy link
Contributor Author

Forcing the repository to use node 10, makes coverage work just fine.

... or not.

However, removing node_modules/.cache/esm/ before running coverage does work.

@artfulhacker
Copy link

I turned off cache in the nyc config and now it works without removing the node_modules/.cache/esm/

@mroderick mroderick closed this Jan 22, 2021
@andrezero
Copy link
Owner

This is quite embarrassing!

I have been locked away most of the time in GHE at my job and never realised there was a PR here until you closed it 🤦

Kudos @mroderick and @artfulhacker for the feedback! I am quite glad someone found this boilerplate useful. I never had anyone star or fork any project ever so this is all quite surprising for me!

I actually only used the boilerplate a couple of times. I mostly do these boilerplates once every couple of years and purely for research purposes, to establish the state of the art.

I will probably do one in 2021 and will take inspiration from this!

@andrezero
Copy link
Owner

@mroderick I also noticed I may have caused some frustration to people trying to make nyc work here https://github.com/andrezero/boilerplate-esm-nyc-mocha/issues

Do you believe this boilerplate is still relevant in 2021? If so, do you mind reopening a PR with all the tweaks you have done on your side?

If not I will probably add a big warning to the README!

@mroderick
Copy link
Contributor Author

I think this boilerplate is still very relevant, as it shows people that it's still possible to get work done with minimal use of packages.

@andrezero andrezero merged commit adb86fc into andrezero:master Jan 27, 2021
@andrezero
Copy link
Owner

it shows people that it's still possible to get work done with minimal use of packages

very ❤️ warming @mroderick and uplifting

thank you so much for not giving up on me

@mroderick mroderick deleted the upgrade-dependencies branch January 30, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants