Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Add initial implementation of Gopenpgp-backed PGP #1441

Merged
merged 19 commits into from
Jul 11, 2021
Merged

Add initial implementation of Gopenpgp-backed PGP #1441

merged 19 commits into from
Jul 11, 2021

Conversation

msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Jun 20, 2021

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Adds alternate implementations of GPG-handling activities which use Gopenpgp, and a simple feature flag to prevent this code from being exposed end users of snapshots.

💡 Motivation and Context

Work towards #1195

The intent of this PR is to demonstrate viability, and little more. It has no immediate benefits to users, and only serves to create an MVP that must be reworked as and when we start implementing new supporting functionality.

💚 How did you test it?

Verified with hard-coded credentials that encryption and decryption work.

📝 Checklist

  • I formatted the code ./gradlew spotlessApply
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

  • Add key management UI
  • Decide on whether or not a passphrase cache should be implemented

@msfjarvis msfjarvis added this to the v2.0.0 milestone Jun 20, 2021
@msfjarvis msfjarvis added A-PGP Area: OpenKeychain-backed PGP A-UI-UX Area: General UI/UX concerns C-feature Category: This is a feature request C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-medium Effort: This requires a fair amount of work P-high Priority: high, must be resolved before next major release S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jun 20, 2021
@msfjarvis msfjarvis force-pushed the gopenpgp branch 2 times, most recently from ae83af4 to 507b3d2 Compare June 20, 2021 15:07
@msfjarvis
Copy link
Member Author

msfjarvis commented Jun 20, 2021

TODO for myself

@msfjarvis msfjarvis force-pushed the gopenpgp branch 4 times, most recently from 62ad397 to fb6e07c Compare June 29, 2021 00:41
@msfjarvis msfjarvis removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jun 29, 2021
@msfjarvis msfjarvis changed the title Add initial implementation of Gopenpgp-backed decryption Add initial implementation of Gopenpgp-backed PGP Jun 29, 2021
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Copy link
Member Author

I'm going to mark this as ready for review since the code here is basically done until #1446 is complete, which'll take some time.

To test this, you'll have to hard-code your PGP private key and passphrase at the bottom of GopenpgpDecryptActivity, and your PGP public key at the bottom of GopenpgpPasswordCreationActivity. The keys must be exported with --armor for now, that may or may not change by the time #1446 is done.

@msfjarvis msfjarvis marked this pull request as ready for review July 11, 2021 16:26
@msfjarvis msfjarvis requested a review from a team as a code owner July 11, 2021 16:26
@msfjarvis msfjarvis enabled auto-merge (squash) July 11, 2021 17:16
@msfjarvis msfjarvis merged commit 6e4ffe2 into develop Jul 11, 2021
@msfjarvis msfjarvis deleted the gopenpgp branch July 11, 2021 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-PGP Area: OpenKeychain-backed PGP A-UI-UX Area: General UI/UX concerns C-feature Category: This is a feature request C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-medium Effort: This requires a fair amount of work P-high Priority: high, must be resolved before next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants