Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M1 Ninja #1548

Closed
Tracked by #1299
DanAlbert opened this issue Jul 26, 2021 · 14 comments
Closed
Tracked by #1299

M1 Ninja #1548

DanAlbert opened this issue Jul 26, 2021 · 14 comments
Assignees

Comments

@DanAlbert
Copy link
Member

Subtask for #1299

@DanAlbert
Copy link
Member Author

(removing from the project because this isn't tied to an NDK release, it's in the SDK)

@enh-google
Copy link
Collaborator

did this go out in this week's Studio update?

@DanAlbert
Copy link
Member Author

No, we were two weeks faster :) #1545 (comment)

It's still in canary, which is why the bugs remain open.

@rprichard
Copy link
Collaborator

The Android SDK's ninja binary is distributed as part of the cmake package.

@enh-google
Copy link
Collaborator

do we know (roughly?) the timeline when that'll go from canary to stable?

@DanAlbert
Copy link
Member Author

We could ambitiously do that any time, but I think it'd be wise to flip the Studio default version before we do that. We don't have any way to know if it's been used by anyone but @rprichard yet.

@DanAlbert
Copy link
Member Author

(I'm planning to move the Studio default Soon, once I'm done doing fixing their default NDK)

@enh-google
Copy link
Collaborator

sgtm. i'm just very confused this week about what "released" even means in Studio land :-)

@DanAlbert
Copy link
Member Author

aiui cmake/ninja being in canary means that anyone can use it as long as they enable the canary channel. No updates there are forced so it's safe to do, but it'll recommend canary updates for other packages so it might be annoying. I think you can enable the canary channel, install cmake, then go back to stable though?

@rprichard
Copy link
Collaborator

I think you can enable the canary channel, install cmake, then go back to stable though?

I believe this is the case. It'll also be necessary to set the cmake version in gradle, e.g.:

    externalNativeBuild {
        cmake {
            path file('src/main/cpp/CMakeLists.txt')
            version '3.22.1'
        }
    }

@vmilea
Copy link

vmilea commented Feb 12, 2022

I'm planning to move the Studio default Soon

What will be the new default?

FWIW - I've been using CMake 3.22.1 from canary with NDK r23b and r24 RC1. No issues so far, and build times on my M1 mac have almost halved with the arm64 Clang. Thank you!

@DanAlbert
Copy link
Member Author

What will be the new default?

3.22.1

FWIW - I've been using CMake 3.22.1 from canary with NDK r23b and r24 RC1. No issues so far, and build times on my M1 mac have almost halved with the arm64 Clang. Thank you!

Glad to hear it! We're moving a little slowly in the transition from canary -> stable at least in part because we aren't sure how widely the new version has been used yet. One vote of confidence is hardly data, but at least we can feel good about it :)

@DanAlbert
Copy link
Member Author

AGP 7.3 Canary 8 should use CMake 3.22.1 (which includes ninja) by default. We'll give that some soak time (unsure how long we ought to wait, but probably not more than a month) and then promote it to the stable channel.

bootstraponline pushed a commit to Flank/mirror-goog-studio-main that referenced this issue Apr 21, 2022
Test: treehugger
Bug: android/ndk#1545
Bug: android/ndk#1548

Change-Id: I029f9fa6bc01702d13b4e8b4545f6460f5cfa759
@DanAlbert
Copy link
Member Author

Okay, now that r25 is out, CMake 3.22.1 (which includes ninja) is in the stable channel.

AGP's default still needs to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants