Skip to content

Commit

Permalink
Apply guidance from issuetracker
Browse files Browse the repository at this point in the history
b/287312019

Change-Id: I3c89605e1707ac25d3726e37e9254085cd698191
  • Loading branch information
keyboardsurfer committed Sep 12, 2024
1 parent d39055a commit 58888d3
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/Build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ jobs:
- name: Checkout
uses: actions/checkout@v4

- name: Enable KVM group perms
run: |
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm
ls /dev/kvm
- name: Copy CI gradle.properties
run: mkdir -p ~/.gradle ; cp .github/ci-gradle.properties ~/.gradle/gradle.properties

Expand Down Expand Up @@ -109,13 +116,6 @@ jobs:
disable_globbing: true
commit_message: "🤖 Updates screenshots"

- name: Enable KVM group perms
run: |
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm
ls /dev/kvm
# Run local tests after screenshot tests to avoid wrong UP-TO-DATE. TODO: Ignore screenshots.
- name: Run local tests
if: always()
Expand Down
8 changes: 4 additions & 4 deletions benchmarks/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ android {
}

testOptions.managedDevices.devices {
create<com.android.build.api.dsl.ManagedVirtualDevice>("pixel5Api33") {
device = "Pixel 5"
create<com.android.build.api.dsl.ManagedVirtualDevice>("pixel6Api33") {
device = "Pixel 6"
apiLevel = 33
systemImageSource = "aosp_atd"
systemImageSource = "aosp"
}
}

Expand All @@ -60,7 +60,7 @@ android {
baselineProfile {
// This specifies the managed devices to use that you run the tests on.
managedDevices.clear()
managedDevices += "pixel5Api33"
managedDevices += "pixel6Api33"

// Don't use a connected device but rely on a GMD for consistency between local and CI builds.
useConnectedDevices = false
Expand Down

0 comments on commit 58888d3

Please sign in to comment.