Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Upgrade to AGP 8.4 #1433

Closed
2 tasks done
jvandort opened this issue May 13, 2024 · 3 comments · Fixed by #1434
Closed
2 tasks done

[FR]: Upgrade to AGP 8.4 #1433

jvandort opened this issue May 13, 2024 · 3 comments · Fixed by #1434
Labels
enhancement New feature or request

Comments

@jvandort
Copy link

jvandort commented May 13, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the problem

Gradle uses NIA as a sample project for its performance tests. Since NIA is not compatible with AGP 8.4, we cannot update Gradle's tests to perform validations against AGP 8.4. These include both our smoke tests and performance benchmarks, as they both test against the same AGP versions.

Describe the solution

Update NIA to build with AGP 8.4

Additional context

This blocks the following Gradle PR: gradle/gradle#29102

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jvandort
Copy link
Author

@alexvanyo You upgraded to 8.3 last time. How difficult do you think this upgrade will be?

@SimonMarquis
Copy link
Contributor

SimonMarquis commented May 13, 2024

@dependabot should have taken care of it like in this PR:

Unfortunately, I think the project accumulated too many open PRs:

open-pull-requests-limit: 10

Shameless nudge:

@jvandort
Copy link
Author

Thank you for the quick turn-around time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants