Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AGP to 8.4.0, Android Build Tools to 31.4.0, and Gradle to 8.7. #1434

Merged
merged 3 commits into from
May 14, 2024

Conversation

lihenggui
Copy link
Contributor

@lihenggui lihenggui commented May 13, 2024

What I have done and why
That's the minimum change for upgrading AGP to 8.4.0
Fixes #1433

Package From To
com.android.tools.lint:lint-api 31.3.0 31.4.0
com.android.tools.lint:lint-checks 31.3.0 31.4.0
com.android.tools.lint:lint-tests 31.3.0 31.4.0
com.android.tools:common 31.3.0 31.4.0
com.android.tools.build:gradle 8.3.0 8.4.0
com.android.application 8.3.0 8.4.0
com.android.library 8.3.0 8.4.0
com.android.test 8.3.0 8.4.0
androidx.benchmark:benchmark-macro-junit4 1.2.3 1.2.4
androidx.baselineprofile 1.2.3 1.2.4
Gradle 8.5 8.7

Updates com.android.tools.lint:lint-api from 31.3.0 to 31.4.0

Updates com.android.tools.lint:lint-checks from 31.3.0 to 31.4.0

Updates com.android.tools.lint:lint-tests from 31.3.0 to 31.4.0

Updates com.android.tools:common from 31.3.0 to 31.4.0

Updates com.android.tools.lint:lint-checks from 31.3.0 to 31.4.0

Updates com.android.tools.lint:lint-tests from 31.3.0 to 31.4.0

Updates com.android.tools.build:gradle from 8.3.0 to 8.4.0

Updates com.android.application from 8.3.0 to 8.4.0

Updates com.android.library from 8.3.0 to 8.4.0

Updates com.android.test from 8.3.0 to 8.4.0

Updates com.android.tools:common from 31.3.0 to 31.4.0

Updates com.android.application from 8.3.0 to 8.4.0

Updates com.android.library from 8.3.0 to 8.4.0

Updates com.android.test from 8.3.0 to 8.4.0

Updates androidx.benchmark:benchmark-macro-junit4 from 1.2.3 to 1.2.4

Updates androidx.baselineprofile from 1.2.3 to 1.2.4

Updates Gradle from 8.5 to 8.7

How I'm testing it

Choose at least one:

  • ✔️ Unit tests
  • ✔️ UI tests
  • ✔️ Screenshot tests

Do tests pass?

  • [✔️] Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • [✔️] Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

Is this your first pull request?
No

Copy link
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, looks good to me!

@dturner
Copy link
Collaborator

dturner commented May 14, 2024

Thanks very much for the PR, including a well written description @lihenggui, and thanks for the review @alexvanyo.

@dturner dturner merged commit b85cf7d into android:main May 14, 2024
4 checks passed
@lihenggui lihenggui deleted the ml/agp8_4 branch May 15, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Upgrade to AGP 8.4
3 participants