Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce icon sizes #1673

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Reduce icon sizes #1673

merged 1 commit into from
Oct 21, 2024
+2 −2

Conversation

dturner
Copy link
Collaborator

@dturner dturner commented Oct 21, 2024

What I have done and why
The topic icons were, for some reason, extremely large compared to the rest of the content. This PR simply reduces the icon sizes on the topic list and detail screens to make more space for other content.

Before After
image image
image image

@dturner dturner requested a review from riggaroo October 21, 2024 14:44
riggaroo
riggaroo approved these changes Oct 21, 2024
View reviewed changes
Copy link

@riggaroo riggaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 42.34% -0.05% 🍏
Files changed 12.82% ❌

Module Coverage
topic 44.67% 🍏
ui 29.54% -0.53% ❌
Files
Module File Coverage
topic TopicScreen.kt 45.88% 🍏
ui InterestsItem.kt 0% -1.99% ❌

@dturner dturner merged commit ecea15d into main Oct 21, 2024
4 checks passed
@dturner dturner deleted the dt/fix-icons branch October 21, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riggaroo riggaroo riggaroo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dturner @riggaroo