Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Retrofit R8 issue, bump version to 0.1.2 #861

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

dturner
Copy link
Collaborator

@dturner dturner commented Jul 27, 2023

This fixes an issue where data would not load from the backend because of an exception thrown by retrofit. Users would see a loading spinner for a short time but no new data would be loaded from the server. The following would be seen in logcat:

2023-07-26 15:59:15.186 12572-12678 suspendRunCatching      com...gle.samples.apps.nowinandroid  I  Failed to evaluate a suspendRunCatchingBlock. Returning failure Result
                                                                                                    java.lang.ClassCastException: java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType

Cause: square/retrofit#3751
Solution: Add proguard rules to stop Retrofit type information being removed

Change-Id: Ia90d693731c95248211b12b1ce2e9dfab0ecf34c
@dturner dturner merged commit 7c38944 into main Jul 27, 2023
1 of 2 checks passed
@dturner dturner deleted the fix-retrofit branch July 27, 2023 17:03
@SimonMarquis
Copy link
Contributor

For reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants