Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded topic names in NavigationTest.kt #862

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Remove hardcoded topic names in NavigationTest.kt #862

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
250850c
Remove hardcoded topic names in `NavigationTest.kt`
SimonMarquis Jul 27, 2023
bf5fdb4
Update NavigationTest.kt
SimonMarquis Jul 27, 2023
0a1f333
Update NavigationTest.kt
SimonMarquis Jul 27, 2023
57f3700
Select last topic by name instead of a random one
SimonMarquis Jul 28, 2023
d8a6d0d
Replace NiaNetworkDataSource with TopicsRepository
SimonMarquis Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions app/src/androidTest/java/com/google/samples/apps/nowinandroid/ui/NavigationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,25 @@ import androidx.compose.ui.test.junit4.AndroidComposeTestRule
import androidx.compose.ui.test.junit4.createAndroidComposeRule
import androidx.compose.ui.test.onAllNodesWithText
import androidx.compose.ui.test.onNodeWithContentDescription
import androidx.compose.ui.test.onNodeWithTag
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.performClick
import androidx.compose.ui.test.performScrollToNode
import androidx.test.espresso.Espresso
import androidx.test.espresso.NoActivityResumedException
import com.google.samples.apps.nowinandroid.MainActivity
import com.google.samples.apps.nowinandroid.R
import com.google.samples.apps.nowinandroid.core.network.NiaNetworkDataSource
import com.google.samples.apps.nowinandroid.core.rules.GrantPostNotificationsPermissionRule
import dagger.hilt.android.testing.BindValue
import dagger.hilt.android.testing.HiltAndroidRule
import dagger.hilt.android.testing.HiltAndroidTest
import kotlinx.coroutines.test.runTest
import org.junit.Before
import org.junit.Rule
import org.junit.Test
import org.junit.rules.TemporaryFolder
import javax.inject.Inject
import kotlin.properties.ReadOnlyProperty
import com.google.samples.apps.nowinandroid.feature.bookmarks.R as BookmarksR
import com.google.samples.apps.nowinandroid.feature.foryou.R as FeatureForyouR
Expand Down Expand Up @@ -78,6 +84,9 @@ class NavigationTest {
@get:Rule(order = 3)
val composeTestRule = createAndroidComposeRule<MainActivity>()

@Inject
lateinit var datasource: NiaNetworkDataSource

private fun AndroidComposeTestRule<*, *>.stringResource(@StringRes resId: Int) =
ReadOnlyProperty<Any?, String> { _, _ -> activity.getString(resId) }

Expand All @@ -92,6 +101,9 @@ class NavigationTest {
private val brand by composeTestRule.stringResource(SettingsR.string.brand_android)
private val ok by composeTestRule.stringResource(SettingsR.string.dismiss_dialog_button_text)

@Before
fun setup() = hiltRule.inject()

@Test
fun firstScreen_isForYou() {
composeTestRule.apply {
Expand Down Expand Up @@ -251,11 +263,14 @@ class NavigationTest {
}

@Test
fun navigationBar_multipleBackStackInterests() {
fun navigationBar_multipleBackStackInterests() = runTest {
composeTestRule.apply {
onNodeWithText(interests).performClick()
// TODO: Grab string from fake data
onNodeWithText("Android Studio & Tools").performClick()

// Select a random topic
val topic = datasource.getTopics().random().name
SimonMarquis marked this conversation as resolved.
Show resolved Hide resolved
onNodeWithTag("interests:topics").performScrollToNode(hasText(topic))
onNodeWithText(topic).performClick()

// Switch tab
onNodeWithText(forYou).performClick()
Expand All @@ -264,7 +279,7 @@ class NavigationTest {
onNodeWithText(interests).performClick()

// Verify we're not in the list of interests
onNodeWithText("Android Auto").assertDoesNotExist() // TODO: Grab string from fake data
onNodeWithTag("interests:topics").assertDoesNotExist()
}
}
}