Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle topic clicks from all destinations #868

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

SimonMarquis
Copy link
Contributor

Closes #865

@SimonMarquis SimonMarquis marked this pull request as draft July 28, 2023 17:50
@SimonMarquis
Copy link
Contributor Author

SimonMarquis commented Jul 28, 2023

There are probably more instances of this callback to be fixed 👀
Or something else related to the NavHostController that is broken.
With this set of changes, the behavior is now bugged:

  • Open ForYou screen
  • Click on a topic tag
  • The interest screen opens
  • Click on the "For you" tab, but nothing happen 🐛

@mmoczkowski mmoczkowski marked this pull request as ready for review August 23, 2023 15:04
@mmoczkowski mmoczkowski self-requested a review August 23, 2023 15:04
Copy link
Contributor

@mmoczkowski mmoczkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now sure why those callbacks were left empty. Thank you for your contribution!

@mmoczkowski mmoczkowski merged commit 851ca63 into android:main Aug 23, 2023
5 checks passed
@SimonMarquis SimonMarquis deleted the patch-4 branch August 23, 2023 15:26
@lelelongwang
Copy link

I found two bugs:

  • bug 1: When you execute onTopicClick in foryouScreen to enter the topicScreen, and then click foryouItem on the navigationbaritem, you cannot jump to foryouScreen.

Solution 1: It can be consistent with "Interests", when jumping from foryouScreen to topicScreen, "Foryou" is still selected

Solution 2: After jumping from foryouScreen to topicScreen, if "Interests" is selected, clicking "Foryou" should enter foryouScreen

  • bug 2: When I execute onTopicClick again in topicScreen, I do not enter the new topicScreen according to the new topic ID, which means that in the topicScreen interface, the onTopicClick interface does not change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Tapping on a topic chip doesn't open the topic detail screen
3 participants