-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dependabot updates on a weekly basis #893
Conversation
Does this support dependency grouping? https://medium.com/androiddevelopers/automating-dependency-updates-in-a-compose-project-168ef5e89ac5 |
Ok in that case kotlin, Compose compiler and KSP should be grouped. https://github.com/android/architecture-templates/blob/main/renovate.json Also, daily would probably be overwhelming. I'd start with weekly. |
I'll update this PR to reflect these groups |
I haven't used dependabot yet but this LGTM |
FWIW, here is an example of grouped update with dependabot: SimonMarquis/SealedObjectInstances#136 |
using the `version update` label for gradle updates.
c81deae
to
7133de7
Compare
🔔 @dturner @JoseAlcerreca @alexvanyo (sorry for the ping 🙈) What is the current status of this PR? It could prevent the need to manually create PRs like in these recent ones: If we want to stick with the third party @renovate-bot, I'm fine with it (even though I kind of dislike the fact to give write permissions to a third party), but then we should allow independent updates. Because right now, it is configured to bundle all updates at the same time, and prevents us to easily update -and test- dependencies atomically. |
PTAL 🔔 @dturner @JoseAlcerreca @alexvanyo Sorry for the 2nd ping, but it's been almost 4 months 🙈, any comment on this? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will also check with @JoseAlcerreca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok let's try dependabot
😎 Awesome! Now we need to find a process to validate these reviews in a timely manner. I'd love to be able to approve them, but it would require you to give more permissions to individual users. Not sure if this is something you are willing to do. We could also try to auto-approve and merge all patches/minor updates if the CI does not fail. |
Two dependencies might be missed in the dependabot configuration file. https://github.com/android/nowinandroid/blob/main/gradle/init.gradle.kts#L17 |
@SimonMarquis Yeah, completely understand that it can be frustrating to have PRs sat for months without being reviewed/merged. We have a mandate to ensure that the app shows best practices and that can lead to lengthy internal discussions, or worse no discussions because people don't have the bandwidth to discuss or review. I'll investigate whether we can grant certain approval permissions to external contributors to speed things up. @jdkoren Please could you investigate #893 (comment) |
Regarding spotless/ktlint versions, they are currently part of an init script, and therefore can't access the main version catalog. Possible solutions:
|
version update
label for Gradle updatesℹ️ General Availability of grouped updates