New Sample for ActivityResultContracts.RequestPermission() #8

Canato · 2020-09-14T20:12:37Z

close #7

Description

Run permissions on Android 11
Usage of JAVA_8
Using appCompat version 1.3.0-alpha02
Usage of androidx libraries

Create to give a previous sample using the code from Request App Permissions

Obs:

The main change is on MainActivity.kt if compare with the other kotlin module.
Most snack bar now have action on it, because was not possible to see the snackbar before (change of activity) and this will bring clearness for the user of what is happening.
The name of the folder should be temporary until appCompat release 1.3 stable.

Open for folder name suggestion and/or any other code suggestion

Disclaimer

Already sign the license as noted on CONTRIBUTING.md. Waiting for answer

nic0lette · 2020-09-15T19:05:41Z

RuntimePermissionsBasicKotlinActivityResultContractsRequestPermission/local.properties

@@ -0,0 +1,8 @@
+## This file must *NOT* be checked into Version Control Systems,


Please don't check this file into source control. :)

nic0lette · 2020-09-15T19:07:18Z

...estPermission/Application/src/main/java/com/example/android/basicpermissions/MainActivity.kt

+ */
+class MainActivity : AppCompatActivity(), ActivityCompat.OnRequestPermissionsResultCallback {
+
+    private lateinit var layout: View


Please convert the sample to use view binding.

nic0lette · 2020-09-15T19:10:03Z

...ssion/Application/src/main/java/com/example/android/basicpermissions/camera/CameraPreview.kt

+    }
+
+    companion object {
+        private val TAG = "CameraPreview"


This should be const (and you could consider moving it to be a top level constant at the top of the file).

nic0lette · 2020-09-15T19:11:56Z

...ssion/Application/src/main/java/com/example/android/basicpermissions/camera/CameraPreview.kt

+ * Implementation is based directly on the documentation at
+ * http://developer.android.com/guide/topics/media/camera.html
+ */
+class CameraPreview @JvmOverloads constructor(


There's probably no reason for the @JvmOverloads here, since this class isn't being consumed by any Java programming language callers.

nic0lette · 2020-09-15T19:13:05Z

...plication/src/main/java/com/example/android/basicpermissions/camera/CameraPreviewActivity.kt

+            // Create the Preview view and set it as the content of this Activity.
+            val cameraPreview = CameraPreview(this, null,
+                    0, camera, cameraInfo, displayRotation)
+            findViewById<FrameLayout>(R.id.camera_preview).addView(cameraPreview)


Please convert the class to use view binding.

nic0lette · 2020-09-15T19:14:10Z

...plication/src/main/java/com/example/android/basicpermissions/camera/CameraPreviewActivity.kt

+     * A safe way to get an instance of the Camera object.
+     */
+    private fun getCameraInstance(cameraId: Int): Camera? {
+        var c: Camera? = null


Perhaps use a better name than c for the variable.

nic0lette · 2020-09-15T19:54:13Z

...BasicKotlinActivityResultContractsRequestPermission/Application/src/main/AndroidManifest.xml

+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+          package="com.example.android.basicpermissions">
+
+    <!-- BEGIN_INCLUDE(manifest) -->


Consider removing this comment (along with the END_INCLUDE one below)

nic0lette · 2020-09-15T19:55:34Z

RuntimePermissionsBasicKotlinActivityResultContractsRequestPermission/.google/packaging.yaml

+status:       PUBLISHED
+technologies: [Android]
+categories:   [Permissions]
+languages:    [Java]


Sorry, I forgot to note this: Please change this to [Kotlin] :)

nic0lette · 2020-09-15T19:57:35Z

Thanks for the contribution! I know a bunch of the comments actually also apply to the existing Kotlin sample, but it would be nice to improve this one not only to use the activity result library but also other improvements :)

Canato · 2020-09-15T21:08:48Z

Thanks for the contribution! I know a bunch of the comments actually also apply to the existing Kotlin sample, but it would be nice to improve this one not only to use the activity result library but also other improvements :)

Hey @nic0lette thanks for the review.

One question, since this camera API is even the new one.
Would make sense to remove the camera files and just open the device camera? since the goal here are the permissions and not the camera.

If yes, I will remove and address the other comments

nic0lette · 2020-09-15T22:14:34Z

One question, since this camera API is even the new one.
Would make sense to remove the camera files and just open the device camera? since the goal here are the permissions and not the camera.

I'm not sure. Yes, the goal is to show the permission flow, but it's nice to also see the result of it.

Let's leave the deprecated Camera API usage for now, and then update it to use CameraX in the future. (Even if you'd like to do that part, I think we should do it in a separate PR)

(The name for the sample (directory) is also a bit intense? How would you feel about something like PermissionsActivityResultKotlin or even ActivityResultBasicKotlin since it's in the permissions-samples repo?)

Canato · 2020-09-27T13:42:57Z

@nic0lette thanks for the tips. sorry for the long time until I address it.

Change the folder to PermissionsActivityResultKotlin much better name ^^

Thanks for pushing the view binding, I had not give the time before to check it and now I understand why is better compared with Kotlin Synthetic

Just add the new code, let me know anything!

Canato · 2020-10-20T12:40:06Z

Hey @codingjeremy sorry to disturb, not sure the best way of helping here. First time committing in the Android Repo, something I could do or need to do to help this PR?

Canato · 2020-10-30T14:10:59Z

@tiembo @nic0lette @codingjeremy I add the changes I saw in #11 let me know if something is off ^^
Thanks

Canato · 2020-11-17T09:37:58Z

Hey people any news? =D

Sorry to disturb @tiembo @codingjeremy

AiezMansor · 2020-11-18T02:08:33Z

Sent from Yahoo Mail on Android On Sel, Nov 17, 2020 at 5:38 PTG, Victor Canato<notifications@github.com> wrote: Hey people any news? =D Sorry to disturb @tiembo @codingjeremy — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Merge pull request #1 from android/master

Canato · 2020-11-30T12:10:29Z

Added latest changes into my branch/PR
@tiembo @nic0lette @codingjeremy

Canato · 2020-12-23T10:05:30Z

Good day and almost merry Christmas

Any news here?
@nic0lette @nic0lette @codingjeremy @ggfan @owahltinez

Canato · 2021-01-14T09:17:49Z

Good morning and happy new year =D

Let me know if need more changes or we are waiting for the final release, appcompat is now on beta01

Canato · 2021-02-01T09:22:13Z

Thanks @themar7777 !

Just to let you know I cannot merge 😭

Only those with write access to this repository can merge pull requests.

Hahaha so feel free to merge it when you can =)

Canato · 2021-02-28T11:15:45Z

Hey @tiembo any news for this PR? =D

nic0lette · 2021-03-15T12:35:13Z

Thank you for the sample. :)

Canato added 6 commits September 14, 2020 19:26

Copy kotlin basic sample

28aa37c

Remove onActivityResult add registerForActivityResult

9d9dbff

Clean code

dca685f

update README

7a232fb

Merge branch 'register_for_activity_sample'

46612dd

change folder name

e4ae323

nic0lette self-requested a review September 15, 2020 18:45

nic0lette reviewed Sep 15, 2020

View reviewed changes

Canato added 9 commits September 27, 2020 13:41

Change folder name

ef1e126

ignore

2fcac44

fix packaging.yaml language

da32956

Remove comments not need in Manifest

0dccb1a

improve variable name

d8098f0

remove Java notation

82a67b9

Extract TAG for a top level const

d0ac0d6

Usage of view binding

dc5bef6

Return gitignore to origin

62fa8f3

codingjeremy changed the base branch from master to main September 29, 2020 19:10

Canato requested a review from nic0lette October 7, 2020 20:50

codingjeremy requested a review from tiembo October 9, 2020 22:18

Canato added 2 commits October 30, 2020 14:00

updates

31e4ec7

add dependencies

f516906

Merge pull request #1 from android/master

3fb0652

Merge pull request #1 from android/master

Canato mentioned this pull request Dec 23, 2020

Gallery option is not showing CanHub/Android-Image-Cropper#20

Closed

themar7777 approved these changes Jan 31, 2021

View reviewed changes

This was referenced Feb 9, 2021

New ActivityResultContracts.RequestPermission() sample #7

Closed

Add support for 'Never ask again' option #1

Open

nic0lette merged commit 3fb0652 into android:main Mar 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Sample for ActivityResultContracts.RequestPermission() #8

New Sample for ActivityResultContracts.RequestPermission() #8

Canato commented Sep 14, 2020 •

edited

Loading

nic0lette Sep 15, 2020

nic0lette Sep 15, 2020

nic0lette Sep 15, 2020

nic0lette Sep 15, 2020

nic0lette Sep 15, 2020

nic0lette Sep 15, 2020

nic0lette Sep 15, 2020

nic0lette Sep 15, 2020

nic0lette commented Sep 15, 2020

Canato commented Sep 15, 2020

nic0lette commented Sep 15, 2020

Canato commented Sep 27, 2020

Canato commented Oct 20, 2020

Canato commented Oct 30, 2020

Canato commented Nov 17, 2020

AiezMansor commented Nov 18, 2020 via email

Canato commented Nov 30, 2020

Canato commented Dec 23, 2020

Canato commented Jan 14, 2021

Canato commented Feb 1, 2021

Canato commented Feb 28, 2021

nic0lette commented Mar 15, 2021

		@@ -0,0 +1,8 @@
		## This file must NOT be checked into Version Control Systems,

New Sample for ActivityResultContracts.RequestPermission() #8

New Sample for ActivityResultContracts.RequestPermission() #8

Conversation

Canato commented Sep 14, 2020 • edited Loading

Description

Obs:

Disclaimer

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nic0lette commented Sep 15, 2020

Canato commented Sep 15, 2020

nic0lette commented Sep 15, 2020

Canato commented Sep 27, 2020

Canato commented Oct 20, 2020

Canato commented Oct 30, 2020

Canato commented Nov 17, 2020

AiezMansor commented Nov 18, 2020 via email

Canato commented Nov 30, 2020

Canato commented Dec 23, 2020

Canato commented Jan 14, 2021

Canato commented Feb 1, 2021

Canato commented Feb 28, 2021

nic0lette commented Mar 15, 2021

Canato commented Sep 14, 2020 •

edited

Loading