Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds splashscreen for Wear 3 #1028

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Adds splashscreen for Wear 3 #1028

merged 1 commit into from
Mar 11, 2024

Conversation

kul3r4
Copy link
Contributor

@kul3r4 kul3r4 commented Mar 8, 2024

Add splashscreen for Wear 3 by following guidance from https://developer.android.com/reference/androidx/core/splashscreen/SplashScreen.
It adds a theme file and a splashscreen.xml so that we can define sizes (otherwise the icon is too big.)
Also adds adaptive icons both for launcher and splashscreen.

@kul3r4
Copy link
Contributor Author

kul3r4 commented Mar 8, 2024

@ithinkihaveacat take a look for the addition of the adaptive icons if it looks good.
@garanj FYI

<resources xmlns:tools="http://schemas.android.com/tools">
<style name="Theme.App" parent="@android:style/Theme.DeviceDefault" />

<style name="Theme.App.Starting" parent="Theme.SplashScreen">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - correct based on docs for splashscreen, but I am wondering whether we can simplify that to use more defaults?

@kul3r4
Copy link
Contributor Author

kul3r4 commented Mar 10, 2024

@yschimke
The issue when not specifying

 android:width="@dimen/splash_screen_icon_size"
        android:height="@dimen/splash_screen_icon_size"

even if you use parent="Theme.SplashScreen.IconBackground", it's that you will get a different icon from the launcher in size. Attaching video.
Screen_recording_20240310_210018.webm

Was the suggestion to remove dimens.xml?

@yschimke
Copy link
Contributor

I think we should fix the library to use the correct defaults!

But for now, this is correct.

@yschimke
Copy link
Contributor

Going to land, to play around with. Any further comments in a follow up?

Hope this is ok @kul3r4

@yschimke yschimke merged commit 61f1b14 into android:main Mar 11, 2024
3 checks passed
@yschimke
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants