-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds splashscreen for Wear 3 #1028
Conversation
@ithinkihaveacat take a look for the addition of the adaptive icons if it looks good. |
<resources xmlns:tools="http://schemas.android.com/tools"> | ||
<style name="Theme.App" parent="@android:style/Theme.DeviceDefault" /> | ||
|
||
<style name="Theme.App.Starting" parent="Theme.SplashScreen"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this extend Theme.SplashScreen.IconBackground from https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:core/core-splashscreen/src/main/res/values/styles.xml?q=Theme.SplashScreen.IconBackground
And could we use the default values from https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:core/core-splashscreen/src/main/res/values-watch/dimens.xml;l=26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - correct based on docs for splashscreen, but I am wondering whether we can simplify that to use more defaults?
@yschimke
even if you use Was the suggestion to remove dimens.xml? |
I think we should fix the library to use the correct defaults! But for now, this is correct. |
Going to land, to play around with. Any further comments in a follow up? Hope this is ok @kul3r4 |
@kul3r4 from https://issuetracker.google.com/issues/256678037 - it seems like the values 72/90 in https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:core/core-splashscreen/src/main/res/values-watch/dimens.xml;l=26 are deliberate. Should we reopen this issue? |
Add splashscreen for Wear 3 by following guidance from https://developer.android.com/reference/androidx/core/splashscreen/SplashScreen.
It adds a theme file and a splashscreen.xml so that we can define sizes (otherwise the icon is too big.)
Also adds adaptive icons both for launcher and splashscreen.