Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds notice regarding watch face development changes #1148

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Conversation

garanj
Copy link
Contributor

@garanj garanj commented Jul 10, 2024

Adds notice regarding watch face development changes

@garanj garanj requested a review from khufdev July 10, 2024 14:38
@@ -5,6 +5,11 @@ Android Complications Sample
Complication Test Suite is a set of complication data sources that provide dummy data and it can be
used to test how different types of complications render on a watch face.

> [!IMPORTANT]
> As of July 10, 2024, watch faces must use the [Watch Face Format][1] ([sample][3]) in order to be installed on new watches that launch with Wear OS 5 pre-installed. Learn more about the user-facing changes in this [Help Center][2] article.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect recycling of reference links (which we use at the end of the introduction)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've fixed this!

Copy link

@khufdev khufdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one instance of reference links sending readers to the incorrect page

@@ -9,8 +9,9 @@ Demonstrates watch faces using the androidX libraries (Kotlin).

Introduction
------------
The AndroidX watch face libraries allow you to develop a watch face service in Kotlin. However,
[WFF][1] is strongly recommended in preference to this approach.
The AndroidX watch face libraries allow you to develop a watch face service in Kotlin.
Copy link

@khufdev khufdev Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd want to keep the recommendation to use Watch Face Format, right? (Maybe this is a merge conflict?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think I've fixed this!

Copy link

@khufdev khufdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better, thanks!

@garanj garanj merged commit 1cc17dd into main Jul 10, 2024
3 checks passed
@garanj garanj deleted the wff-notice branch July 10, 2024 16:26
@LouisCAD
Copy link
Contributor

There are no nice words for what's happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants