apply responsive tiles to alarm, calendar, news, timer, mediation #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
approved these changes
Aug 5, 2024
| @@ -61,6 +62,7 @@ fun News(context: Context) = TilePreviewData { | |||
| it.deviceConfiguration, | |||
| headline = "Millions still without power as new storm moves across US", | |||
| newsVendor = "The New York Times", | |||
| date = LocalDate.now().minusDays(1), | |||
There was a problem hiding this comment.
I can see the appeal of both options, but is it worth using a fixed date for previews.
Particularly given future screenshot testing of previews?
There was a problem hiding this comment.
@yschimke
I think you are exactly right!
I want to display yesterday, I changed it using a fixed Clock.
|
Nit: the calendar preview shows a layout issue. But might be ok to demonstrate how reviews can highlight problems and solve later. |
|
I wonder this is a bug in the library. |
|
Let's land as is and follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I applied responsive tiles to alarm, calendar, news, timer, meditation.