-
Notifications
You must be signed in to change notification settings - Fork 440
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Handle
C.TIME_END_OF_SOURCE
buffer timestamps in CeaDecoder
The behaviour was changed in 1.4.0 with 0f42dd4, so that the buffer timestamp is compared to `outputStartTimeUs` when deciding whether to discard a "decode only" buffer before decoding (instead of the deprecated/removed `isDecodeOnly` property). This breaks when the buffer timestamp is `TIME_END_OF_SOURCE` (which is `Long.MIN_VALUE`), because `TIME_END_OF_SOURCE < outputStartTimeUs` is always true, so the end-of-stream buffer is never passed to the decoder and on to `TextRenderer` where it is used to [set `inputStreamEnded = true`](https://github.com/androidx/media/blob/40f187e4b47c445af5049a5a49ee4633ce4c1a76/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/text/TextRenderer.java#L434-L436) and so playback hangs. Issue: #1863 PiperOrigin-RevId: 695767247 (cherry picked from commit 19b38c8)
- Loading branch information
Showing
3 changed files
with
25 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters