Enable CBR seeking for files with unknown length in AmrExtractor

Constant bit rate (CBR) seeking can be enabled even when the length of the file is not known. Additionally, dump files for these files have been updated to accurately log the `position` when `timeUs` is set to `0`. PiperOrigin-RevId: 662868607
androidx · Aug 14, 2024 · e9cfd72 · e9cfd72
1 parent ca455ee
commit e9cfd72
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/amr/AmrExtractor.java b/libraries/extractor/src/main/java/androidx/media3/extractor/amr/AmrExtractor.java
@@ -381,7 +381,6 @@ private void maybeOutputSeekMap(long inputLength, int sampleReadResult) {
     }
 
     if ((flags & FLAG_ENABLE_CONSTANT_BITRATE_SEEKING) == 0
-        || inputLength == C.LENGTH_UNSET
         || (firstSampleSize != C.LENGTH_UNSET && firstSampleSize != currentSampleSize)) {
       seekMap = new SeekMap.Unseekable(C.TIME_UNSET);
       extractorOutput.seekMap(seekMap);

diff --git a/libraries/test_data/src/test/assets/extractordumps/amr/sample_nb_cbr.amr.unknown_length.dump b/libraries/test_data/src/test/assets/extractordumps/amr/sample_nb_cbr.amr.unknown_length.dump
@@ -1,7 +1,7 @@
 seekMap:
   isSeekable = false
   duration = UNSET TIME
-  getPosition(0) = [[timeUs=0, position=0]]
+  getPosition(0) = [[timeUs=0, position=6]]
 numberOfTracks = 1
 track 0:
   total output bytes = 2834

diff --git a/libraries/test_data/src/test/assets/extractordumps/amr/sample_wb_cbr.amr.unknown_length.dump b/libraries/test_data/src/test/assets/extractordumps/amr/sample_wb_cbr.amr.unknown_length.dump
@@ -1,7 +1,7 @@
 seekMap:
   isSeekable = false
   duration = UNSET TIME
-  getPosition(0) = [[timeUs=0, position=0]]
+  getPosition(0) = [[timeUs=0, position=9]]
 numberOfTracks = 1
 track 0:
   total output bytes = 4056