HttpEngine should use RequiresExtension

[yschimke]

HttpEngine is marked as @RequiresApi(34)

media/libraries/datasource/src/main/java/androidx/media3/datasource/HttpEngineDataSource.java

Line 69 in d13a0f4

@RequiresApi(34)

But HttpEngine is based on extension versions

@RequiresExtension(extension = Build.VERSION_CODES.S, version = 7)

In practice trying to configure HttpEngine and pass it to HttpEngineDataSource, Android Studio wanted me to add both.

Should HttpEngineDataSource be changed to use RequiresExtension, so that it works on API 31 devices that have received the latest mainline versions?

[marcbaechinger]

Thanks for raising this!

I think we should do what makes the least hassle for our users. So if AS complains, we probably should do this.

For my education: with @RequiresApi I know how I as a developer can code and take different API levels into account. Like

if (Util.SDK_INT >= 21) {
  // here
}

How would that work with such a @RequiresExtension annotation? Do you know?

[yschimke]

SdkExtensions.getExtensionVersion(Build.VERSION_CODES.S) >= 7

It should clear IDE errors when you check this.

[icbaker]

This was done in 91633e6, which was then reverted and then re-done in 00d1e70.