Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification play/pause button doesn't match player state #192

Closed
1 task
JaCobbMedia opened this issue Oct 20, 2022 · 1 comment
Closed
1 task

Notification play/pause button doesn't match player state #192

JaCobbMedia opened this issue Oct 20, 2022 · 1 comment
Assignees
@tianyif
Labels
bug needs triage

Comments

@JaCobbMedia
Copy link

Media3 Version

1.0.0-beta02

Devices that reproduce the issue

  • Pixel 5 (Android 13)
  • Samsung Galaxy S21 Ultra (Android 12)

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

  1. Start demo-session app
  2. Play any item (was easiest to reproduce on "Mango Open Movie project")
  3. Click on play/pause button
  4. It doesn't happen often so you might need to click it multiple times

I could reproduce this issue even with my custom MediaNotificationProvider which chooses play/pause button icon by playWhenReady flag.

Expected result

Play/pause notification button should match current player state

Actual result

Play/pause notification button doesn't match player state (player is paused but notification shows pause button, should show play button)

Media

Album folder -> Mango Open Movie project -> Future Scenario

Bug Report
@christosts christosts self-assigned this Oct 20, 2022
@christosts christosts assigned tianyif and unassigned christosts Nov 15, 2022
christosts pushed a commit that referenced this issue Feb 14, 2023
@tianyif @christosts
Update notification play/pause button with matching player state
e1d12fc 
Issue: #192
PiperOrigin-RevId: 508649684
@tianyif
Copy link
Contributor

tianyif commented Feb 17, 2023

Fixed in e1d12fc.

@tianyif tianyif closed this as completed Feb 17, 2023
tonihei pushed a commit that referenced this issue Mar 2, 2023
@tianyif @tonihei
Update notification play/pause button with matching player state
ad42800 
Issue: #192
PiperOrigin-RevId: 508649684
(cherry picked from commit e1d12fc)
@androidx androidx locked and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tianyif tianyif

Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tianyif @JaCobbMedia @christosts