Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling skip silence breaks the output #712

Closed
JureSencar opened this issue Oct 9, 2023 · 3 comments
Closed

Toggling skip silence breaks the output #712

JureSencar opened this issue Oct 9, 2023 · 3 comments
Assignees
Labels

Comments

@JureSencar
Copy link

JureSencar commented Oct 9, 2023

Version

Media3 1.1.1

This did not happen in ExoPlayer 2.18.7 library.

Devices that reproduce the issue

Pixel 6a Android 13

Reproducible in the demo app?

Yes

Reproduction steps

In PlayerActivity replace the body in onClick with

  @Override
  public void onClick(View view) {
    player.setSkipSilenceEnabled(!player.getSkipSilenceEnabled());
  }

Then open and play any file (e.g. Google Play (MP3)).
Press the button a few times. Sometimes it is enough to just turn it on and off, sometimes it takes a few clicks.

Expected result

The media continues playing normally with the latest skipSilenceEnabled applied.

Actual result

The sound at the output gets corrupted until a user performs seek operation.

Media

This seems to be independent from the container and source type (stream or local file).

@tianyif
Copy link
Contributor

tianyif commented Oct 9, 2023

Hi @JureSencar,

Thanks for reporting! I can reproduce this issue even on ExoPlayer 2.19.0, while 2.18.7 is not reproducible. @tonihei I feel that the commit google/ExoPlayer@3d82846 is suspicious, would it be possible that this commit causes the issue here?

@tianyif tianyif assigned tonihei and unassigned tianyif Oct 9, 2023
@tonihei
Copy link
Collaborator

tonihei commented Oct 16, 2023

Turns out, the change that broke this is 52f3ee8 (verified by syncing directly before and at this change)

@Samrobbo Could you take a look to see what may have caused this issue?

@tonihei tonihei assigned Samrobbo and unassigned tonihei Oct 16, 2023
naveensingh added a commit to FossifyOrg/Music-Player that referenced this issue Oct 17, 2023
copybara-service bot pushed a commit that referenced this issue Dec 11, 2023
copybara-service bot pushed a commit to google/ExoPlayer that referenced this issue Dec 11, 2023
@droid-girl
Copy link
Contributor

Hi @JureSencar, the fix is in the main branch

microkatz pushed a commit that referenced this issue Jan 11, 2024
Issue: #712
PiperOrigin-RevId: 589882412
(cherry picked from commit 90a0cbd)
@androidx androidx locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants