Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DV profile 10 handling in getAlternativeCodecMimeType() method #1389

Merged
merged 2 commits into from
May 28, 2024
Merged

Add DV profile 10 handling in getAlternativeCodecMimeType() method #1389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e060c92
Merge pull request #9 from androidx/main
ybai001 May 23, 2024
205bbef
Add DV profile 10 handling in getAlternativeCodecMimeType() method
ybai001 May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libraries/exoplayer/src/main/java/androidx/media3/exoplayer/mediacodec/MediaCodecUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,8 @@ public static String getAlternativeCodecMimeType(Format format) {
return MimeTypes.AUDIO_E_AC3;
}
if (MimeTypes.VIDEO_DOLBY_VISION.equals(format.sampleMimeType)) {
// H.264/AVC or H.265/HEVC decoders can decode the base layer of some DV profiles. This can't
// be done for profile CodecProfileLevel.DolbyVisionProfileDvheStn and profile
// H.264/AVC, H.265/HEVC or AV1 decoders can decode the base layer of some DV profiles.
// This can't be done for profile CodecProfileLevel.DolbyVisionProfileDvheStn and profile
// CodecProfileLevel.DolbyVisionProfileDvheDtb because the first one is not backward
// compatible and the second one is deprecated and is not always backward compatible.
@Nullable Pair<Integer, Integer> codecProfileAndLevel = getCodecProfileAndLevel(format);
Expand All @@ -362,6 +362,8 @@ public static String getAlternativeCodecMimeType(Format format) {
return MimeTypes.VIDEO_H265;
} else if (profile == CodecProfileLevel.DolbyVisionProfileDvavSe) {
return MimeTypes.VIDEO_H264;
} else if (profile == CodecProfileLevel.DolbyVisionProfileDvav110) {
return MimeTypes.VIDEO_AV1;
}
}
}
Expand Down