Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for RTSP H263 #63
Add support for RTSP H263 #63
Changes from 4 commits
55bfe71
ffa04ea
ff80a41
f8cd3a9
aae9f23
dfc424d
fc3c57e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VRC != 0
, you should log the actual value of VRC, PLEN and PEBIT.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are unable to find clip(s) which are having these special headers to add support and verify it.
These special header are used for error resilience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have difficulty understanding here: if picture start code is
0b100000
which is 64, then it'll always fail the checkstartCodePayload < PICTURE_START_CODE
. Maybe you quoted a wrong RFC section?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Picture start code is "100000" from msb, so it is 128. If startCodePayload is less than 128 then packet is follow-On.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very strange that a method starts with
get
does not return anything, and forgetBufferFlagsAndResolutionFromVop
to depend on whether the output format is set (isOutputFormatSet
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getBufferFlagsAndResolutionFromVop() method returns Buffer flags as well as Resolution, so i'm using class variable to get both values. I'm using "isOutputFormatSet" variable to check if outputformat is already set or not, as we need to update actual resolution once throughout decode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, if the method does not return anything, can you rename it to
parseVopHeader
and specify it sets width/height/flags in the javadoc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the reason to name this
shortHeader
? It's not of typeshort
and I can't find reference to any 'short' in the RFCThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its taken from h263 decoder. Added link for the same in javaDoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain a bit here? I'm particularly lost why the shift bits are derived from a
sourceFormat
. Is the related logic in the H263 spec? I can't find it in RFC4629.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://cs.android.com/android/platform/superproject/+/master:frameworks/av/media/codecs/m4v_h263/dec/src/vop.cpp;l=1128. According to this logic :
sourceFormat 2 is 176x144, sourceFormat 3 is 1762x1442, sourceFormat 4 is 17622x14422 and so on.