Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose mode #112

Merged
merged 3 commits into from
Oct 15, 2014
Merged

Verbose mode #112

merged 3 commits into from
Oct 15, 2014

Conversation

andresilva
Copy link
Contributor

As discussed in #111. If you have any ideas regarding other output to suppress by default let me know.

@andsens
Copy link
Owner

andsens commented Oct 12, 2014

This looks great! Could you add the opposite test case as well? i.e.

@test 'normal verbosity should not print identical messages when linking'

Otherwise a nice and simple change, with a second test you can consider this merged :-)

@andresilva
Copy link
Contributor Author

Done! Unfortunately due to this I wasn't able to use the run function from bats.

@andsens
Copy link
Owner

andsens commented Oct 15, 2014

Unfortunately due to this I wasn't able to use the run function from bats.

Interesting.. Gotta make a mental note of that :-)
The code works nicely and the tests fail without it, thank you!
Merging...

andsens added a commit that referenced this pull request Oct 15, 2014
@andsens andsens merged commit 500b66e into andsens:development Oct 15, 2014
@andresilva
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants