-
Notifications
You must be signed in to change notification settings - Fork 215
Intl.js with polyfill not working on Safari #256
Comments
Ok, I will try to do the release tomorrow morning. |
@caridy Any chance of doing a release? |
@caridy friendly reminder |
Any news on this release @caridy? |
As a workaround you can use v1.2.4 for now. But definitely project needs more collaborators! |
@chicoxyzzy unfortunately that is not an option when using it with polyfill.io... 😞 |
@Turbo87 Remove it from polyfill.io and polyfill it yourself for a while until it is fixed. A bloated bundle is better than a broken site. |
@ruiaraujo to be honest I'd rather work on fixing the cause of the problem, but that unfortunately seems harder than I hoped... |
@reiniergs is helping with the tests at the moment, trying to get the test suite back to life, and validate that we are good. We don't want to push a broken build again (like the RegExp issue from last time). I'm currently out until the second week of January. Apologies for the inconvenience, and I will be very supportive of more hands on the deck, if someone has time to help. |
@caridy thanks for the feedback! can you elaborate on what is wrong with the test suite? any way we can help? |
@Turbo87 the saucelab config is a mess at the moment. On top of that, errors happening during the testing process are completely obscure (at the moment there are ~18 failures on IE, but the error tells nothing about the actual error). |
Um.. just a little note that while waiting for the fix, we can also disable "RegExp cache / restore" as explained in the documentation if you want to use latest version (or if you must, thank to polyfill.io) I'm not sure about everyone's cases, but it works for mine and I also think the document is right that it "is not strictly necessary" and you can disable it. |
Same happening on on 1.2.5 IE10, 1.2.4 works fine |
I just ran into this problem with the npm package for NodeJS (thus not Polyfill.io)...
One proposed solution above about disabling RegExp cache doesn't work.
Edit: see #231 |
Intl 1.2.5 No news about it? |
Based on PR and issue discussions it looks like #244 fixed this, but there hasn't been a release since 11/16/16 when it was merged. |
Wow it has been so long since this issue appear.. Now we even already dropped support for Safari < 10, which is the reason we need to use this library in the first place 😂 |
Meanwhile downgrade to 1.2.4..it's works fine! |
This is still an issue. We hard coded 1.2.4 and removed the carot from our package.json for now. |
Thanks to @dvkndn, disabling regex caching seems to fix the problem for me as well: Intl.__disableRegExpRestore() |
Also having
But the workaround won't work in this case: // Determine if the built-in `Intl` has the locale data we need
if (!are_intl_locales_supported(locales))
{
// `Intl` exists, but it doesn't have the data we need, so load the
// polyfill and patch the constructors we need with the polyfill's
Intl.NumberFormat = Intl_polyfill.NumberFormat
Intl.DateTimeFormat = Intl_polyfill.DateTimeFormat
} Hard-coding version
Node.js server-side rendering will still need it because Node only comes prepackaged with English language. |
This should hopefully address andyearnshaw/Intl.js#256 and not break anything else
Due to andyearnshaw/Intl.js/issues/256, the Intl polyfill has to be pinned at v1.2.4. It breaks on Safari 9 and using older version should fix the broken tests.
Fixes an issue where polyfill.io no longer works as expected to load necessary polyfills via feature detections or UA detection. A quick patch is to replace modern features with compatible codes to ensure Chrome 41 is able to load and run the datepicker without any issues. `pointerup` -> `click` event listener on scrim of `<AppDatepickerDialog>`. Due to andyearnshaw/Intl.js/issues/256, the Intl polyfill has to be pinned at v1.2.4. It breaks on Safari 9 and using older version should fix the broken tests.
Fixes an issue where polyfill.io no longer works as expected to load necessary polyfills via feature detections or UA detection. A quick patch is to replace modern features with compatible codes to ensure Chrome 41 is able to load and run the datepicker without any issues. `pointerup` -> `click` event listener on scrim of `<AppDatepickerDialog>`. Due to andyearnshaw/Intl.js/issues/256, the Intl polyfill has to be pinned at v1.2.4. It breaks on Safari 9 and using older version should fix the broken tests.
It's not available outside the browser, which is still something lots of people face (Node, react-*). |
This change adds a workaround for an issue with the Intl.js polyfill library where it instantiates an invalid regular expression. Relevant issues: andyearnshaw/Intl.js#270 andyearnshaw/Intl.js#256 andyearnshaw/Intl.js#306 Until this issue is fixed upstream, we use a workaround in the example. Fixes: vercel#11777
This change adds a workaround for an issue with the Intl.js polyfill library where it instantiates an invalid regular expression. Relevant issues: andyearnshaw/Intl.js#270 andyearnshaw/Intl.js#256 andyearnshaw/Intl.js#306 Until this issue is fixed upstream, we use a workaround in the example. Fixes: vercel#11777
* Add workaround for Intl.js RegEx issue This change adds a workaround for an issue with the Intl.js polyfill library where it instantiates an invalid regular expression. Relevant issues: andyearnshaw/Intl.js#270 andyearnshaw/Intl.js#256 andyearnshaw/Intl.js#306 Until this issue is fixed upstream, we use a workaround in the example. Fixes: #11777 * Do not load Intl.js polyfill by default on Node This change updates the `with-react-intl` example to prevent it from polyfilling `Intl` in a Node environment when it is not needed.
We were using this library successfully but for some reason it stopped working last Friday.
When loading the html that includes the Intl polyfill reference (https://cdn.polyfill.io/v2/polyfill.min.js?features=Intl.~locale.en) the following errors are displayed in Safari:
The result is a blank page instead of the expected content loaded.
Not sure if this is an Intl.js error, or a polyfill one, but any help would be greatly appreciated!
The text was updated successfully, but these errors were encountered: