This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
using standard polyfill wrapping pattern to access global scope in multiple runtimes #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing
window
object directly is not recommended because it bound this polyfill to a browser. Other polyfills are using a more elegant solution to access the global scope.With this PR, we can guarantee:
this
(which iswindow
in the browser, andglobal
in nodejs) as the global scope to augment it withIntl
member.OldIntl
on the global scope (even though it is not used in this script at the moment).Intl
will be created everytime that this script gets evaluated.