Run server.closeAllConnections() before server.close() #666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue that was encountered on another Node.js app with a Neo4j database in which after a change was made to the code which triggered a Nodemon restart of the server, it would be impossible to close the server using
ctrl
+c
and would require that the entire CLI shell was closed.Upon the sixth attempt at
ctrl
+c
, the following message would appear:Each attempt of
ctrl
+c
would callserver.close()
twice (but not invoke the callback), so the sixth attempt would reach the 11th call, indicating that each call would add a close listener.I'm not sure of the exact cause, but the below references helped lead me to a solution.
References:
server.closeAllConnections()