Skip to content

Commit

Permalink
refactor: remove the "photo" plugin
Browse files Browse the repository at this point in the history
A consensus was reached that this plugin is generally not useful, and
never fulfilled its intended use of integrating with e.g. KItinerary.
Since it's apparently been broken for some time, and the "share" plugin
works just as well, it's being removed.
  • Loading branch information
andyholmes committed Sep 14, 2023
1 parent f1e5adc commit 117ebc0
Show file tree
Hide file tree
Showing 25 changed files with 431 additions and 1,511 deletions.
2 changes: 0 additions & 2 deletions build-aux/contrib/valent.spec
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ BuildRequires: pkgconfig(libpeas-1.0) %{libpeas_version}
BuildRequires: pkgconfig(libportal) %{libportal_version}
BuildRequires: pkgconfig(sqlite3) %{sqlite_version}
BuildRequires: pkgconfig(gstreamer-1.0)
# TODO: For `photo` plugin
BuildRequires: pkgconfig(gstreamer-video-1.0)
# For `pulseaudio` plugin
BuildRequires: pkgconfig(libpulse)
BuildRequires: pkgconfig(libpulse-mainloop-glib)
Expand Down
12 changes: 0 additions & 12 deletions doc/schemas/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -141,18 +141,6 @@
"https://invent.kde.org/network/kdeconnect-android/tree/master/src/org/kde/kdeconnect/Plugins/ReceiveNotificationsPlugin"
]
},
{
"title": "Photo Plugin",
"description": "The Photo plugin allows requesting a device to take a photo and then transferred the result.",
"packets": [
"kdeconnect.photo",
"kdeconnect.photo.request"
],
"references": [
"https://invent.kde.org/network/kdeconnect-kde/tree/master/plugins/photo",
"https://invent.kde.org/network/kdeconnect-android/tree/master/src/org/kde/kdeconnect/Plugins/PhotoPlugin"
]
},
{
"title": "Ping Plugin",
"description": "The Ping plugin allows sending and receiving simple 'pings', with an optional message. Usually these are displayed as notifications.",
Expand Down
45 changes: 0 additions & 45 deletions doc/schemas/kdeconnect.photo.json

This file was deleted.

31 changes: 0 additions & 31 deletions doc/schemas/kdeconnect.photo.request.json

This file was deleted.

6 changes: 0 additions & 6 deletions meson_options.txt
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,6 @@ option('plugin_notification',
value: true,
)

option('plugin_photo',
description: 'Enable Photo plugin',
type: 'boolean',
value: true,
)

option('plugin_ping',
description: 'Enable Ping plugin',
type: 'boolean',
Expand Down
2 changes: 0 additions & 2 deletions po/POTFILES.in
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ src/plugins/notification/valent-notification-dialog.c
src/plugins/notification/valent-notification-dialog.ui
src/plugins/notification/valent-notification-preferences.c
src/plugins/notification/valent-notification-preferences.ui
src/plugins/photo/photo.plugin.desktop.in
src/plugins/photo/valent-photo-plugin.c
src/plugins/ping/ping.plugin.desktop.in
src/plugins/ping/valent-ping-plugin.c
src/plugins/presenter/presenter.plugin.desktop.in
Expand Down
Loading

0 comments on commit 117ebc0

Please sign in to comment.