Skip to content

Commit

Permalink
math: Fix dependencies in filter HiFi selection
Browse files Browse the repository at this point in the history
The intent of the dependencies on this choice seems to be that they
apply only to certain components so the selection should be hidden if
they aren't in use.

But the logic was wrong: instead of enabling it if any component was
enabled that needed it, it would hide the selection unless ALL such
components were enabled.  Which doesn't build.  Fix.

(Also I note the comment implies that other kconfigs should probably
be in the list too, but not adding them out of conservatism as this
is, again, just a hygiene thing.)

Signed-off-by: Andy Ross <andyross@google.com>
  • Loading branch information
andyross committed Dec 18, 2024
1 parent afd2bbf commit 442420b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/math/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,7 @@ endmenu
# this choice covers math iir, math fir, tdfb, and eqfir, eqiir.
choice "FILTER_SIMD_LEVEL_SELECT"
prompt "choose which SIMD level used for IIR/FIR/TDFB module"
depends on COMP_FIR
depends on COMP_IIR
depends on COMP_TDFB
depends on COMP_FIR || COMP_IIR || COMP_TDFB
default FILTER_HIFI_MAX

config FILTER_HIFI_MAX
Expand Down

0 comments on commit 442420b

Please sign in to comment.