chore: export Arguments #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erfanium
approved these changes
Aug 14, 2020
|
Thanks for contributing, guys! |
|
Do you need the change released quickly? |
|
Yes I do. Thank you for approving this PR! |
|
@Alon-L You can install node packages directly from github with npm: https://medium.com/@jonchurch/use-github-branch-as-dependency-in-package-json-5eb609c81f1a This is so useful to me, I no longer have to wait for the changes to be released |
|
Glad you found a quick fix. Released now as v1.3.0, too 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the
Argumentstype useful for dynamic event calls that require the arguments to be passed onto the listener.I believe they should be exported as they serve as a core and useful type in the library.