Point "main" field to index.d.ts #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing this small fix, @thatmarvin! |
|
Thank you for a very helpful package @andywer! |
|
@thatmarvin One last question: Did you check that this fix indeed solves your eslint issue (did you monkeypatch your local |
|
@andywer Yes I did test by monkeypatching locally! |
|
Published as v1.3.1 🚀 |
This was referenced Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enforcing the
no-unresolvedrule with https://www.npmjs.com/package/eslint-plugin-import, eslint will flag this becausemainin package.json defaults toindex.js, which doesn't exist in this repo. So I'm just explicitly defining it here to to fix it.I understand that this is a rather specific issue with using this eslint-plugin-import, but if you can't think of any downsides, it'd be great to get this in!