-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added less block #114
Added less block #114
Conversation
Most importantly, the plugin does not work with Extract Text block, the output is just a string in JS bundle, SASS block does not work with it as well: #115. Second, adding
|
Can you please check which linting issues make the build fail? I will have a look at it myself, but right now I am busy working on the new API (#125). |
@andywer Do we want this in the core? I’d suggest to keep it as a third-party block since Less is way less popular that Sass. |
Since nobody complained recently... I suppose it would make more sense to keep it as a 3rd-party block. |
I don't mind, just tell me how should I take over it. P.S. I personally think that official support of Less is also a very nice to have thing along with official support of Sass. I use both actually, in different projects, because of different advantages. |
Sure and I would appreciate it a lot if you would find some time to publish a We will advertise your block here, too, don't worry. I know I keep saying this for far too long, but we shall have an official list of 3rd-party blocks in a prominent place soon :) |
I could find around 6 third-party blocks on npm, so Readme could be a good place to start — I can send a PR. |
Sure, let's just put it into the readme for now! |
@kirill-konshin Are you still interested in making a third-party block for Less? |
Yes. I will publish it today/tomorrow. What's the naming convention? |
|
https://www.npmjs.com/package/webpack-blocks-less published almost as is based on this PR. Contributions are welcome. This PR can be closed, but please, add a reference to README then... |
@kirill-konshin Awesome! You need to update an example in readme and repository field in package.json — they still point to webpack-blocks repo. And feel free to send a PR to add a link to our Readme ;-) |
Added less block.
@kirill-konshin please test the block since I can't do it for a while.