Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use cache for proto files #360

Merged
merged 10 commits into from
Dec 27, 2022
Merged

ci: use cache for proto files #360

merged 10 commits into from
Dec 27, 2022

Conversation

fdewas-aneo
Copy link
Contributor

Need advices.

@fdewas-aneo fdewas-aneo self-assigned this Dec 22, 2022
@fdewas-aneo
Copy link
Contributor Author

The modifications are commented for now.

@fdewas-aneo fdewas-aneo linked an issue Dec 22, 2022 that may be closed by this pull request
Cache proto generation to avoid API rate limit aneoconsulting/ArmoniK#806
Closed
esoubiran-aneo
esoubiran-aneo suggested changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@esoubiran-aneo esoubiran-aneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu peux ne pas commenter tes modifications. Cela ne changera la pipeline que sur la branche et non sur l'intégralité du repo.

esoubiran-aneo
esoubiran-aneo suggested changes Dec 27, 2022
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@esoubiran-aneo esoubiran-aneo changed the title edit cd-docker.yml and ci.yaml ci: use cache for proto files Dec 27, 2022
@esoubiran-aneo esoubiran-aneo marked this pull request as ready for review December 27, 2022 14:58
esoubiran-aneo
esoubiran-aneo approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@esoubiran-aneo esoubiran-aneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça me semble bon. On verra par la suite si on rencontre des erreurs.

@esoubiran-aneo esoubiran-aneo merged commit 6022d46 into main Dec 27, 2022
@esoubiran-aneo esoubiran-aneo deleted the feat-cache-proto-generation branch August 17, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barbapapazes Barbapapazes Barbapapazes left review comments

@esoubiran-aneo esoubiran-aneo esoubiran-aneo approved these changes

Assignees

@fdewas-aneo fdewas-aneo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache proto generation to avoid API rate limit
3 participants
@fdewas-aneo @Barbapapazes @esoubiran-aneo