-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize TSAI tiler to crop out FOVs #20
base: main
Are you sure you want to change the base?
Conversation
…mask function to support individual core cropping
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small aesthetic thing, and a question about "Z"
coordinates.
Pull Request Test Coverage Report for Build 9131611699Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@kxleow ran into a case where multiple slides need to be supported. That is currently not the case, as we assume the user has only one poslog file per run. This will need to be added into the pipeline. |
Cropping now supports multiple poslog files. |
Alternative to using poslog and imzml for core cropping:
Sub-issue: Find nearest neighbours if centroid not found
|
Ran into a case with >4 TMAs combined and the order of TMAs did not follow a sequential order in the image (left-right or top-bottom). The order of TMAs were found in the warnings generated at the core cropping step. |
What is the purpose of this PR?
Closes #12.
How did you implement your changes
Using the
.imzml
file, and combined with the output from TSAI:Remaining issues
Currently,
generate_glycan_mask
segments out all of the cores at once. The result ofmap_coordinates_to_core_name
, however, can be used to segment out individual cores. We still need to updategenerate_glycan_mask
to handle individual core segmentation.