Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Angular v12 #132

Merged
merged 1 commit into from
May 29, 2021

Conversation

icepeng
Copy link
Contributor

@icepeng icepeng commented May 28, 2021

  • update angular-devkit dependencies
  • use "$id" instead of deprecated "id" for schema

resolve #131

* update angular-devkit dependencies
* use "$id" instead of deprecated "id" for schema
@fmalcher
Copy link
Member

Thank you for your contribution! ❤️ LGTM at first sight.

@JohannesHoppe JohannesHoppe merged commit 76753b0 into angular-schule:master May 29, 2021
@JohannesHoppe
Copy link
Member

@icepeng Many thanks for your support. 😃 👍

I published angular-cli-ghpages@1.0.0-rc.2 to npm. Please test it all and let me know if it works for you.

JohannesHoppe added a commit that referenced this pull request May 29, 2021
@JohannesHoppe
Copy link
Member

JohannesHoppe commented May 29, 2021

I had no error on my machine but our build produced a couple of npm warnings?!

https://github.com/angular-schule/angular-cli-ghpages/actions/runs/887731643

@icepeng
Copy link
Contributor Author

icepeng commented May 29, 2021

Seems like Github Actions node version issue. Latest Angular CLI requires a minimum Node.js version of either v12.14 or v14.15.

@JohannesHoppe
Copy link
Member

@icepeng You were right, the node version was just too old:
2576a32

Now everything is green again! Thanks again for your contribution! 👍

JohannesHoppe added a commit to angular-schule/ngx-deploy-starter that referenced this pull request Nov 20, 2021
* use "$id" instead of deprecated "id" for schema

see angular-schule/angular-cli-ghpages#132
xellafe pushed a commit to xellafe/ngx-deploy-git-repo that referenced this pull request Oct 2, 2024
* use "$id" instead of deprecated "id" for schema

see angular-schule/angular-cli-ghpages#132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Angular v12
3 participants