Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated JSON parser, use workspace helpers #139

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

fmalcher
Copy link
Member

@fmalcher fmalcher commented Nov 5, 2021

fix #138 . This also SEEMS to fix issue #137 – at least I didn't get any similar errors.

Things worth to know:

  • reading/writing the workspace has completely moved to the builtin helpers
  • some error messages have changed
  • the empty options object is automatically removed. We could statically add one option there so that the object is not empty.

see also: https://angular.io/guide/schematics-for-libraries#define-a-generation-rule

src/package.json Outdated Show resolved Hide resolved
@fmalcher fmalcher marked this pull request as draft November 5, 2021 13:19
@fmalcher fmalcher changed the title fix: don't use deprecated JSON parser fix: remove deprecated JSON parser, use workspace helpers Nov 5, 2021
@fmalcher fmalcher force-pushed the ngadd13 branch 3 times, most recently from 1c091f7 to cc8ea0c Compare November 5, 2021 14:44
@fmalcher fmalcher marked this pull request as ready for review November 5, 2021 14:51
@JohannesHoppe
Copy link
Member

Excellent work, this fixes #138 and fixes #137!

@JohannesHoppe JohannesHoppe merged commit aa7ea02 into master Nov 19, 2021
@JohannesHoppe JohannesHoppe deleted the ngadd13 branch November 19, 2021 12:39
@JohannesHoppe
Copy link
Member

I just published angular-cli-ghpages@1.0.0-rc.3 to npm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng add leads to error with Angular 13
2 participants