Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grunt task that copies the final css to scss file #449

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

ronnyrin
Copy link
Contributor

@ronnyrin ronnyrin commented Nov 3, 2016

I know that you don't want to maintain two codebases. With this solution, you won't have to.
We need a way to import the final css in our scss file and currently importing css is not supported.

@codecov-io
Copy link

Current coverage is 100% (diff: 100%)

Merging #449 into master will not change coverage

@@           master   #449   diff @@
====================================
  Files           1      1          
  Lines         906    906          
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
  Hits          906    906          
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 38e0010...378d2ee

@ValentinH
Copy link
Member

Thanks for contributing this.

@ValentinH ValentinH merged commit c3dacc5 into angular-slider:master Nov 3, 2016
@ronnyrin
Copy link
Contributor Author

ronnyrin commented Nov 3, 2016

Thanks, Can you bump the version?

@ValentinH
Copy link
Member

Done -> 5.8.3

@ValentinH
Copy link
Member

Hi @ronnyrin, it seems that this PR breaks other people builds: #477 . What do you think of the solution propose there to import raw CSS?

@ronnyrin
Copy link
Contributor Author

ronnyrin commented Dec 9, 2016

Maybe we can just rename the scss file so there will be no conflict. Importing raw CSS didn't work for me.

@ValentinH
Copy link
Member

Are you using a recent version of SASS like explain in the linked issue?

@ronnyrin
Copy link
Contributor Author

ronnyrin commented Dec 9, 2016

Yes. It doesn't work.. I'm using grunt-contrib-compass

 error app/styles/main.scss (Line 18 of app/styles/components/...: File to import not found or unreadable: angularjs-slider/dist/rzslider.
Load paths:
  /Users/..../app/bower_components
✗ ./node_modules/node-sass/bin/node-sass -v
node-sass       3.10.1  (Wrapper)       [JavaScript]
libsass         3.3.6   (Sass Compiler) [C/C++]```

@ValentinH
Copy link
Member

It seems that you are missing the .css part of your file pat, don't you?

@ronnyrin
Copy link
Contributor Author

No, if you add the .css suffix then it just transform it to @import url(file.css); and that won't work at all because the browser won't look in the bower folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants