Very low performance on collapse

[drawveloper]

I've been working to optimize the performance of my Angular app.

I have found that this particular line invoking a watch is responsible for something like 15% of my watch expressions total time.

Maybe there is a more performatic way of tackling this problem?

(btw, thanks for the incredible library you guys are building.)

[pkozlowski-opensource]

@Gadr Thnx for the info. Yes, collapse definitively needs some love and watching HTML properties is very bad idea, indeed.... This directive was written early at the beginning of this project and didn't get proper attention since then.

I'm planning to spend some time on it while moving to the BS3 markup but any helping hands would be highly appreciated.

[drawveloper]

I've got my hands incredibly full until Januray :( But I'll try and help
with some parts ASAP. Specially html-unsafe popover, which Im in bad need
of!

On Fri, Nov 1, 2013 at 2:45 PM, Pawel Kozlowski notifications@gh.neting.ccwrote:

@Gadr https://github.com/gadr Thnx for the info. Yes, collapse
definitively needs some love and watching HTML properties is very bad idea,
indeed.... This directive was written early at the beginning of this
project and didn't get proper attention since then.

I'm planning to spend some time on it while moving to the BS3 markup but
any helping hands would be highly appreciated.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1222#issuecomment-27579967
.

[pkozlowski-opensource]

The offensive watch was added in this commit:
bc0fecf

I guess it was added for some corner case as removing it doesn't break the collapse, at least not in the obvious way. Need to see what tests are going to fail when we remove this watch.

[drawveloper]

Nice! Thank you. will update asap.