Rating does not work properly with dynamic max value

[Darkein]

Hi Everybody,
First, thanks for your job, it's very usefull.

I have the same issue than #1547, but with rating, the max value is not dynamically re-evaluated. Can you modify it in the meantime?

thanks!

[bekos]

@Darkein It's the same approach as the progressbar, but I am curious about your use case. Can you explain plz?

[Darkein]

I've created a dynamic form, loaded from the server. the data ("max", value", etc) are added in the scope from another directive, in its link function.
But infortunately, even with a high priority, the link function is called after the ratingcontroller function.

I think the max value should be set in the link function of the rating directive (or in the scope, with '@'), not directly in its controller

[bekos]

Yes, making it a @ and parsing as integer is a good solution anyway, since this will also saves one $watch.

[Darkein]

Glad you like it :)

[pkozlowski-opensource]

But using @ will force us to do type conversion, trying to second-guess what people are trying to pass (an int, as string that parses to int or complete nonsense...).

[bekos]

Max can be nothing else other than integer. If cannot be parsed as integer then it is an error we must through, no?

[bekos]

For now we can move the code for the attributes evaluation inside the initialization code, and talk about @ in another issue :-)

[Darkein]

It's okay for me, should fix the issue in my case