Datepicker leaks memory when used in presence of jquery

[ankit5990]

When datepicker is used in an application which has jQuery included as well, then datepicker is seen to leak memory.

The scope of the controller on which datepicker is used is seen to leak when an investigation of heap is done.

I have created a plunker to show this issue.
http://embed.plnkr.co/qRZEMgBRNIBRjE1fTcCM/
On repeatedly opening and closing a page with datepicker on it, leaks memory which is never reclaimed on GC cycle.

[cyrilwiz]

+1

[karora23]

+1

[chrisirhc]

Thanks for posting this. I've done some investigation to this. It looks like an AngularJS bug with jQuery's cache. It's jQuery's caching that's keeping the references to the scopes. The newest AngularJs version seems to have fixed most of the leaking.

Your Plunker (Angular 1.2.10):

Angular 1.3.0-beta.14:

Angular 1.3.0-rc.0:

Notice there are differences in the y-axis scaling, but look at the "Selected Size" value.

Here's the Plunker I used:
http://plnkr.co/edit/MupMyWCj4oMUonz5EMA7?p=preview

[suyash1208]

+1

[ashishgoyal86]

+1

[ankit5990]

I have made the fix in the code for this issue. Its a very small fix, datepickerPopup directive creates a popupElement div in the code which needed to be removed. I have created plunkers for comparison.

Plunk without fix:-
http://embed.plnkr.co/CYV8uXKv1O7ODkFroee4/

Plunk after fix:-
http://embed.plnkr.co/buFTsQp7TMsbNRlKXTKf/preview

Memory usage before fix-

Memory usage after fix-

I would like to contribute the change back to the library. @chrisirhc can you help me on how to submit a PR?

[ankit5990]

Created a pull request for the fix
#2684