Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Head Tabset duplicates options in select dropdown #631

Closed
psgibbs opened this issue Jul 6, 2013 · 1 comment
Closed

Head Tabset duplicates options in select dropdown #631

psgibbs opened this issue Jul 6, 2013 · 1 comment

Comments

@psgibbs
Copy link
Contributor

psgibbs commented Jul 6, 2013

In the head version of the latest tabset, there is a bug when using ng-options in a dropdown, causing all choices to be duplicated. Even when not using ng-options, there are still extraneous 'blank' entries in the dropdown.

I assume this regression was caused when tabset was updated to use the outer scope recently (great update, btw), so while this issue is minor, there may be bigger ripple effects from the extra compilation. I've verified that the duplication explicitly happens on the 'compile' line (299 in the linked version above).

http://plnkr.co/edit/ZLljxACI8ra9EwXIUwU9?p=preview

Thanks,
Paul

@ajoslin
Copy link
Contributor

ajoslin commented Jul 8, 2013

Looking at this, thanks

ajoslin added a commit that referenced this issue Jul 8, 2013
* Before, tab content was being transcluded before the tab content area
 was ready. This forced us to disconnect the tab contents from the DOM
 temporarily, then reocnnect them later. This caused a lot of problems.
* Now, neither the tab content or header are transcluded until both
 the heading and content areas are loaded. This is simpler and fixes
 many weird compilation bugs.
@ajoslin ajoslin closed this as completed Jul 8, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants